Skip to content

ci: allow docs changes under any PR title scope - #31773

Merged
ethanndickson merged 2 commits into
mainfrom
ethan/pr-title-docs-scope
Nov 6, 2026
Merged

ethanndickson merged 2 commits into
mainfrom
ethan/pr-title-docs-scope

Conversation

@ethanndickson

Copy link
Copy Markdown
Member

I ran into this on a feat(site) PR that also updated the docs:

Error: PR title scope "site" does not contain all changed files.
Files outside scope:
  - docs/coder-agents/index.md

A frontend or CLI change that comes with a docs update shouldn't have to drop its scope, so the title check now just ignores files under docs/ when the scope is outside docs/. The scope still has to match at least one changed file, and scopes under docs/ (e.g. docs(docs/admin)) are as strict as before. I've updated the rule in AGENTS.md and the PR style guide to match.

As the check runs on pull_request_target, this only takes effect once it's on main.

The PR title check now ignores files under docs/ when the scope is
outside docs/, so a title like feat(site) or feat(cli) still passes
when the PR also updates the docs.
@ethanndickson
ethanndickson marked this pull request as ready for review November 5, 2026 07:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T07:12:44.531890Z 794680c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87d8cd7b9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/contrib.yaml Resolved
@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 794680ca55

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson
ethanndickson merged commit 1986b94 into main Nov 6, 2026
28 of 29 checks passed
@ethanndickson
ethanndickson deleted the ethan/pr-title-docs-scope branch November 6, 2026 01:13
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants