Skip to content

ci: run the docs checker tests in lint-docs - #31768

Merged
ethanndickson merged 2 commits into
mainfrom
ethan/lint-docs-go-tests
Nov 6, 2026
Merged

ethanndickson merged 2 commits into
mainfrom
ethan/lint-docs-go-tests

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

#31647 was a docs-only PR, but it broke TestRepositoryManifest on main (fixed in #31764). That test reads the committed docs/manifest.json, and the Go test jobs skip PRs that don't touch Go, so nothing ran it until it merged.

On a docs-only PR the Go code can't change, so the only Go tests that can start failing are the ones that read the committed docs. Right now that's just scripts/docsredirectscheck and scripts/docsgenfiltercheck, and ./scripts/docs... covers both.

So, we'll just run go test ./scripts/docs... in lint-docs, which already runs whenever docs change and is part of required. The job now installs Go as well. I've skipped go mod download, as these tests only need 6 modules; from an empty module and build cache it took 6s locally.

The docs checker tests read the committed docs, but the Go test jobs skip
docs-only pull requests. A docs-only change broke TestRepositoryManifest
on main without failing any check on its pull request.
@ethanndickson
ethanndickson marked this pull request as ready for review November 5, 2026 03:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T01:25:10.501120Z c9b543d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nickvigilante nickvigilante left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My agent found 2 nits.

Comment thread .github/workflows/ci.yaml Resolved
Comment thread .github/workflows/ci.yaml Resolved
@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: c9b543d7b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson
ethanndickson merged commit 8b5b5d1 into main Nov 6, 2026
68 of 73 checks passed
@ethanndickson
ethanndickson deleted the ethan/lint-docs-go-tests branch November 6, 2026 02:53
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants