Repository navigation
ci: run the docs checker tests in lint-docs - #31768
Merged
Merged
Conversation
The docs checker tests read the committed docs, but the Go test jobs skip docs-only pull requests. A docs-only change broke TestRepositoryManifest on main without failing any check on its pull request.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
nickvigilante
approved these changes
Nov 5, 2026
nickvigilante
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! My agent found 2 nits.
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31647 was a docs-only PR, but it broke
TestRepositoryManifestonmain(fixed in #31764). That test reads the committeddocs/manifest.json, and the Go test jobs skip PRs that don't touch Go, so nothing ran it until it merged.On a docs-only PR the Go code can't change, so the only Go tests that can start failing are the ones that read the committed docs. Right now that's just
scripts/docsredirectscheckandscripts/docsgenfiltercheck, and./scripts/docs...covers both.So, we'll just run
go test ./scripts/docs...inlint-docs, which already runs whenever docs change and is part ofrequired. The job now installs Go as well. I've skippedgo mod download, as these tests only need 6 modules; from an empty module and build cache it took 6s locally.