Repository navigation
fix(coderd/x/chatd): add ACP subagent prompt guidance - #31498
Merged
Merged
Conversation
hugodutka
force-pushed
the
codex/acp-subagent-prompt-guidance
branch
from
October 29, 2026 16:08
dd94da6 to
d9cfc1a
Compare
hugodutka
commented
Oct 29, 2026
| _, ok := tool.(acpSpawnTool) | ||
| return ok | ||
| }) | ||
| prompt = buildSystemPrompt( |
Collaborator
Author
There was a problem hiding this comment.
This block is moved because we need access to tools to check if ACP subagents are available. Previously the system prompt was constructed before the tools were.
hugodutka
marked this pull request as ready for review
October 29, 2026 16:09
ibetitsmike
approved these changes
Oct 29, 2026
Collaborator
|
Adding the tools already bursts anthropic cache so changing the system prompt at the same time doesn't have any more negative impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP tools are exposed without system-prompt guidance for discovering configured harnesses and managing their sessions. Add conditional guidance that points to the spawn schema and explains the spawn, wait, message, and interrupt flow.
Build root tools before assembling the prompt so guidance is included only when ACP spawning is available. Extend schema/gating and turn-tool-policy coverage to keep prompt guidance aligned with exposed tools.
https://linear.app/codercom/issue/CODAGT-1488/add-system-prompt-guidance-for-available-acp-tools