Skip to content

feat(site/src/pages/AgentsPage/components): list non-idle subagents in the overview card - #31410

Merged
jaaydenh merged 30 commits into
mainfrom
tk/overview-card-subagents
Nov 13, 2026
Merged

jaaydenh merged 30 commits into
mainfrom
tk/overview-card-subagents

Conversation

@ThomasK33

@ThomasK33 ThomasK33 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Adds a Subagents section to the overview card view from #31409. It lists at most five subagents that are not idle, with no toggle. A row links to the subagent's chat. When its title is cut off, a tooltip shows it in full on hover and on keyboard focus. Chats can have 100 or more subagents, and the sidebar's chat tree already lists all of them.

Subagents that need the user (error, requires_action) sort first, so the five-row cap hides them last. The order within each group stays as the API returns it, newest first. The heading reads "Subagents · N of M not idle" and counts every subagent. A chat whose subagents are all idle shows that heading instead of "Nothing to show yet".

The prototype in #31260 said "active" and counted errored subagents. The shared isActiveChatStatus leaves errors out, so I kept errors in the list and changed the word to "not idle". That matches the "Idle" label of the waiting status. The wording is an open question for Jaayden in #31412.

Many subagents with the attention statuses first, and a chat with only idle subagents

How to test

  1. Open Storybook at pages/AgentsPage/ChatOverviewCardView, stories ManySubagents and IdleSubagents.
  2. Run pnpm exec vitest run --project=unit src/pages/AgentsPage/components/ChatOverviewCardView.test.tsx in site/.

What to look at first

  1. SubagentsSection: the filter, the sort, the cap, and the count in one component.
  2. OverviewRow: the new link form. Its props type allows onClick or to, never both.
Review history

Follow-up fix: the link row uses the tooltip from #31409, which now opens only for truncated text. A new test focuses a truncated subagent row and checks its accessible description. It fails when the link row skips the tooltip. No existing assertion changed. origin/main reached this branch by merge from #31409.

Polish pass changes: extracted SubagentsSection and named the two status checks isIdle and needsUser. Behavior and test assertions are unchanged.

Declined:

  • Earlier round and final round: delete the view tests for the filter, cap, sort, and count, and the all-idle count, as checks of rendered content. They cover the selection logic, and each fails when the sort or the section condition is reverted. The requester also asked to keep existing assertions unchanged.
  • Final round: a stronger assertion in the all-idle test. Same reason.
  • Final round: inline isIdle. The polish plan named this check on purpose, and it reads next to needsUser.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high

…d view

Add ChatOverviewCardView, the card that a later change shows in the
chat's top-right corner while the right panel is closed. It lists the
chat cost, the uncommitted changes per repository, the pull requests,
and the attachments. A row opens the matching right panel tab through
onOpenTab. A clean repository shows +0 -0, so the card has a Changes
row when AI Gateway turns cost off. Nothing mounts the view yet.
…n the overview card

Add a Subagents section to the overview card. It lists the subagents
that are not idle, at most five, with the ones that need the user
(error, requires action) first, so the cap never hides them. The
heading counts all subagents, so a chat whose subagents are all idle
shows "0 of N not idle" instead of the empty state. A row links to the
subagent's chat.
@ThomasK33
ThomasK33 added this pull request to stack #31413 October 28, 2026 12:44
@ThomasK33
ThomasK33 marked this pull request as ready for review October 29, 2026 14:16
@ThomasK33
ThomasK33 requested a review from jaaydenh October 29, 2026 14:16
@ThomasK33
ThomasK33 requested a review from a team as a code owner October 29, 2026 14:16
…d view

Rename the view file to ChatOverviewCardView.tsx, so the container in a
later change can take ChatOverviewCard.tsx, as AgentChatPage does. Rows
now call onOpenTarget with a target object, so the deep links later only
add a view to it. A titled OverviewListSection replaces the repeated
"if not empty, section around a list" blocks, and RepoDiffStat holds the
+0 -0 placeholder.

A repository without changes is no longer a button: the Git panel lists
only repositories with changes, so the row had nothing to open.
Move the Subagents section into a SubagentsSection that owns the filter,
the five-row cap, and the heading, with isIdle and needsUser naming the
two status groups.
…t into its section and name the clean repository check
# Conflicts:
#	site/src/pages/AgentsPage/components/ChatOverviewCardView.test.tsx
#	site/src/pages/AgentsPage/components/ChatOverviewCardView.tsx
# Conflicts:
#	site/src/pages/AgentsPage/components/ChatOverviewCardView.test.tsx
@ThomasK33
ThomasK33 removed this pull request from stack #31413 October 30, 2026 19:39
@ThomasK33
ThomasK33 added this pull request to stack #31591 October 30, 2026 19:39
@linear-code

linear-code Bot commented Nov 2, 2026

Copy link
Copy Markdown

CODAGT-1517

jaaydenh and others added 6 commits November 3, 2026 09:48
…iew card comments

Keep the JSDoc on exported symbols and the comments that explain non-obvious behavior (cost states, subagent cost scope, attachment order, the clean repository badge, toggle focus, and why rows have tooltips). Drop comments that restate names or the code below them, and the per-story doc comments.
# Conflicts:
#	site/src/pages/AgentsPage/components/ChatOverviewCardView.test.tsx
#	site/src/pages/AgentsPage/components/ChatOverviewCardView.tsx
# Conflicts:
#	site/src/pages/AgentsPage/components/ChatOverviewCardView.tsx
ThomasK33 and others added 9 commits November 3, 2026 11:39
…ins in the overview card with padding

The card now pads by px-1.5 and its headings, empty and loading states, and rows pad themselves, so rows no longer pull outward with -mx-1.5. Text, icons, and hover areas stay in place; section dividers run 6px closer to the card edge.
… in the overview card

The Changes section listed one row per repository but labeled each row
with its branch, so two repositories on the same branch looked the same,
and the toggle counted repositories as changes. Rename the section to
Repositories, label each row with the repository name, and show the
branch as the subtitle.
…ies in the overview card

Show "No branch" when HEAD is detached instead of an empty subtitle, use
a repository icon now that rows name repositories, and drop a test
assertion on rendered output that the tab order test already covers.
Base automatically changed from tk/overview-card-view to main November 10, 2026 12:38
@ThomasK33
ThomasK33 temporarily deployed to main November 10, 2026 12:38 — with GitHub Actions Inactive
…gents

# Conflicts:
#	site/src/pages/AgentsPage/components/ChatOverviewCardView.stories.tsx
#	site/src/pages/AgentsPage/components/ChatOverviewCardView.test.tsx
#	site/src/pages/AgentsPage/components/ChatOverviewCardView.tsx
@jaaydenh
jaaydenh temporarily deployed to main November 10, 2026 13:23 — with GitHub Actions Inactive
@jaaydenh
jaaydenh merged commit 8075cc6 into main Nov 13, 2026
27 checks passed
@jaaydenh
jaaydenh deleted the tk/overview-card-subagents branch November 13, 2026 08:58
@jaaydenh
jaaydenh temporarily deployed to docs-preview November 13, 2026 08:58 — with GitHub Actions Inactive
@jaaydenh
jaaydenh temporarily deployed to main November 13, 2026 08:58 — with GitHub Actions Inactive
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 13, 2026

This branch was previously deployed

2 inactive deployments
docs-preview — 9fb727db Deployed Nov 13, 2026 by jaaydenh via cleanup #22
main — 9fb727db Deployed Nov 13, 2026 by jaaydenh via cla #256006
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants