Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,167 @@
import type { Meta, StoryObj } from "@storybook/react-vite";
import { fn, userEvent, within } from "storybook/test";
import { MockChatDiffStatus } from "#/testHelpers/chatEntities";
import type { MessageAttachment } from "./ChatConversation/messageHelpers";
import {
type ChatOverview,
ChatOverviewCardView,
} from "./ChatOverviewCardView";

const mockAttachment = (
name: string,
mediaType: string,
): MessageAttachment => ({
key: name,
role: "assistant",
file: { type: "file", media_type: mediaType, name, file_id: name },
href: `/api/experimental/chats/files/${name}`,
});

const mockRepo = (
name: string,
branch: string,
additions: number,
deletions: number,
): ChatOverview["repos"][number] => ({
root: `/home/coder/${name}`,
name,
branch,
additions,
deletions,
});

const mockDetachedRepo = mockRepo("provisioner", "", 1, 1);

const mockChatOverview: ChatOverview = {
cost: { total_cost_micros: 23_960_000, unpriced_request_count: 0 },
isSubagent: false,
repos: [mockRepo("coder", "ci/queue-only-jobs", 82, 33)],
pullRequests: [
{
number: "4821",
status: {
...MockChatDiffStatus,
pull_request_title: "ci: queue only the jobs a change needs",
additions: 120,
deletions: 41,
},
},
],
attachments: [
mockAttachment("ci-cost-plan.html", "text/html"),
mockAttachment("flaky-test-report.md", "text/markdown"),
mockAttachment("queue-1440.png", "image/png"),
mockAttachment("queue-1280.png", "image/png"),
],
};

const mockEmptyChatOverview: ChatOverview = {
cost: undefined,
isSubagent: false,
repos: [],
pullRequests: [],
attachments: [],
};

const mockLongChatOverview: ChatOverview = {
...mockChatOverview,
repos: [
mockRepo("api", "feat/a-very-long-branch-name-for-api", 120, 0),
mockRepo("site", "feat/a-very-long-branch-name-for-site", 240, 9),
mockDetachedRepo,
mockRepo("docs", "docs/overview-card", 36, 18),
mockRepo("agent", "fix/agent-git-watcher", 4, 2),
],
};

const meta: Meta<typeof ChatOverviewCardView> = {
title: "pages/AgentsPage/ChatOverviewCardView",
component: ChatOverviewCardView,
args: {
overview: mockChatOverview,
onOpenTarget: fn(),
},
decorators: [
(Story) => (
<div className="p-4">
<Story />
</div>
),
],
};

export default meta;
type Story = StoryObj<typeof ChatOverviewCardView>;

export const Full: Story = {};

export const Empty: Story = {
args: { overview: mockEmptyChatOverview },
};

export const Loading: Story = {
args: { overview: mockEmptyChatOverview, isLoading: true },
};

export const SubagentCost: Story = {
args: {
overview: {
...mockChatOverview,
cost: { total_cost_micros: 4_120_000, unpriced_request_count: 2 },
isSubagent: true,
},
},
};

export const CostUnavailable: Story = {
args: {
overview: { ...mockChatOverview, cost: "unavailable" },
},
};

export const NoCostCleanRepo: Story = {
args: {
overview: {
...mockEmptyChatOverview,
repos: [mockRepo("coder", "main", 0, 0)],
},
},
};

export const TruncatedRowTooltip: Story = {
args: { overview: mockLongChatOverview },
play: async ({ canvasElement }) => {
await userEvent.hover(
within(canvasElement).getByRole("button", {
name: /^api/,
}),
);
},
};

export const TruncatedRowKeyboardFocus: Story = {
args: { overview: mockLongChatOverview },
play: async () => {
// The Cost row comes first, then the row with the truncated branch.
await userEvent.tab();
await userEvent.tab();
},
};

export const ManyRows: Story = {
args: { overview: mockLongChatOverview },
};

export const ManyRowsExpanded: Story = {
args: { overview: mockLongChatOverview },
play: async ({ canvasElement }) => {
const repositories = within(canvasElement).getByRole("region", {
name: "Repositories",
});
await userEvent.click(
within(repositories).getByRole("button", {
name: "Show all 5 repositories",
}),
);
},
};
149 changes: 149 additions & 0 deletions site/src/pages/AgentsPage/components/ChatOverviewCardView.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
import { act, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { MockChatDiffStatus } from "#/testHelpers/chatEntities";
import { renderComponent } from "#/testHelpers/renderHelpers";
import { MockResizeObserver } from "#/testHelpers/resizeObserver";
import {
type ChatOverview,
ChatOverviewCardView,
type OverviewTarget,
} from "./ChatOverviewCardView";

const mockChatOverview: ChatOverview = {
cost: { total_cost_micros: 1_250_000, unpriced_request_count: 0 },
isSubagent: false,
repos: [
{
root: "/home/coder/coder",
name: "coder",
branch: "ci/queue-only-jobs",
additions: 82,
deletions: 33,
},
],
pullRequests: [
{
number: "123",
status: { ...MockChatDiffStatus, pull_request_title: "Queue jobs" },
},
],
attachments: [
{
key: "1:0",
role: "assistant",
file: { type: "file", media_type: "text/html", name: "plan.html" },
href: "/files/plan.html",
},
],
};

const mockCleanRepo: ChatOverview["repos"][number] = {
root: "/home/coder/clean",
name: "clean",
branch: "main",
additions: 0,
deletions: 0,
};

afterEach(() => {
vi.unstubAllGlobals();
vi.restoreAllMocks();
});

/**
* jsdom has no layout, so the test sets the text widths each row measures,
* then reports a resize to every row.
*/
const stubTextWidths = () => {
MockResizeObserver.reset();
vi.stubGlobal("ResizeObserver", MockResizeObserver);
return (widths: { scrollWidth: number; clientWidth: number }) => {
vi.spyOn(HTMLElement.prototype, "scrollWidth", "get").mockReturnValue(
widths.scrollWidth,
);
vi.spyOn(HTMLElement.prototype, "clientWidth", "get").mockReturnValue(
widths.clientWidth,
);
act(() => {
for (const observer of MockResizeObserver.instances) {
observer.simulateResize(widths.clientWidth);
}
});
};
};

const renderCard = (overview = mockChatOverview) => {
const onOpenTarget = vi.fn<(target: OverviewTarget) => void>();
renderComponent(
<ChatOverviewCardView overview={overview} onOpenTarget={onOpenTarget} />,
);
return { onOpenTarget };
};

describe("ChatOverviewCardView", () => {
it.each<{ name: RegExp; tab: OverviewTarget["tabId"] }>([
{ name: /Cost/, tab: "summary" },
{ name: /^coder/, tab: "git" },
{ name: /#123 Queue jobs/, tab: "git" },
{ name: /plan\.html/, tab: "summary" },
])("opens the $tab tab from the row named $name", async ({ name, tab }) => {
const user = userEvent.setup();
const { onOpenTarget } = renderCard();

await user.click(screen.getByRole("button", { name }));

expect(onOpenTarget).toHaveBeenCalledExactlyOnceWith({ tabId: tab });
});

it("opens nothing from a repository without changes", async () => {
const user = userEvent.setup();
const { onOpenTarget } = renderCard({
...mockChatOverview,
repos: [mockCleanRepo],
});

await user.click(screen.getByText("clean"));

expect(onOpenTarget).not.toHaveBeenCalled();
});

it("shows a truncated row's full label in a tooltip on hover", async () => {
const user = userEvent.setup();
const measureText = stubTextWidths();
renderCard();
measureText({ scrollWidth: 200, clientWidth: 100 });

const row = screen.getByRole("button", { name: /#123 Queue jobs/ });
await user.hover(row);

await waitFor(() =>
expect(row).toHaveAccessibleDescription("#123 Queue jobs"),
);
});

it("adds no tooltip to a row whose label fits", () => {
const measureText = stubTextWidths();
renderCard();
measureText({ scrollWidth: 100, clientWidth: 100 });

const row = screen.getByRole("button", { name: /#123 Queue jobs/ });
act(() => row.focus());

expect(row).not.toHaveAccessibleDescription();
});

it("skips a repository without changes in the tab order", async () => {
const user = userEvent.setup();
renderCard({
...mockChatOverview,
cost: undefined,
repos: [mockCleanRepo],
});

await user.tab();

expect(
screen.getByRole("button", { name: /#123 Queue jobs/ }),
).toHaveFocus();
});
});
Loading
Loading