Skip to content

feat: graduate chat projects out of the chat-projects experiment - #31354

Merged
f0ssel merged 3 commits into
mainfrom
remove-chat-projects-experiment
Oct 27, 2026
Merged

f0ssel merged 3 commits into
mainfrom
remove-chat-projects-experiment

Conversation

@f0ssel

@f0ssel f0ssel commented Oct 27, 2026

Copy link
Copy Markdown
Member

Graduates chat projects out of the chat-projects experiment so they are always on (early access). Every backend and frontend gate is removed: project routes, the project_id checks on list/create/update chats, project instructions, skills, and memory in chatd, and all experiments.includes("chat-projects") checks in the Agents UI.

Project sharing is the exception: the project ACL endpoints (GET/PATCH /api/experimental/organizations/{organization}/chats/projects/{project}/acl) now require a new safe experiment, chat-project-sharing. There is no project-sharing UI yet.

Notes for reviewers:

  • Only the ACL endpoints are gated. Shares created before this change still grant access when chat-project-sharing is off. This is intentional.
  • Like the old gate, RequireExperimentWithDevBypass skips the check in dev builds, so tests cannot observe it.
  • Tests that asserted experiment-off behavior were removed. Sidebar and layout stories now stub getChatProjects, since the sidebar always fetches projects.
  • A dedicated projects docs page is in docs(docs): add Coder Agents projects page #30684, which edits the same line in extending-agents.md and will conflict.
Decision log
  • Removed ExperimentChatProjects entirely instead of keeping a no-op constant. A deployment that still sets CODER_EXPERIMENTS=chat-projects gets the existing "ignoring unknown experiment" warning.
  • Gated only the /acl sub-route with chat-project-sharing, using the same middleware the old experiment used.
  • Kept the --disable-chat-sharing deployment check inside the ACL handlers, so both must allow sharing.
  • Left chatProjectsEnabled in ChatsSidebar.tsx as is. It now means "the user has an organization", but the name predates this PR.
  • Checks run: Go build, vet, and golangci-lint on the changed packages; ./coderd/x/chatd/..., ./codersdk/..., ./coderd -run Chat, and the enterprise chat project tests; site tsc, biome, the AgentsPage unit tests, and the affected Storybook files. The frontend-deep-review and doc-check self-checks found nothing blocking after fixes.

Generated by Coder Agents on behalf of @f0ssel.

Chat projects are always on. Project sharing endpoints now require the
new safe chat-project-sharing experiment.
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@f0ssel
f0ssel marked this pull request as ready for review October 27, 2026 17:04
@f0ssel
f0ssel requested review from a team and nickvigilante as code owners October 27, 2026 17:04

@nickvigilante nickvigilante left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

@pr-queue-manager
pr-queue-manager Bot requested a review from jaaydenh October 27, 2026 17:54
@f0ssel
f0ssel merged commit b54f7de into main Oct 27, 2026
30 checks passed
@f0ssel
f0ssel deleted the remove-chat-projects-experiment branch October 27, 2026 22:18
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants