Skip to content

feat: explain deadline changes in the API and workspace tooltip - #31279

Draft
EhabY wants to merge 2 commits into
feat/workspace-deadline-recordingfrom
feat/explain-workspace-keepalive
Draft

EhabY wants to merge 2 commits into
feat/workspace-deadline-recordingfrom
feat/explain-workspace-keepalive

Conversation

@EhabY

@EhabY EhabY commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Depends on #31490. This is the API/presentation layer of the deadline-change stack; storage and deadline recording are reviewed in that PR.

Expose deadline_change on build responses with reason, changed_at, nullable changed_by: MinimalUser, and flat typed sources. Resolve actor and session-app presentation at read time, preserve captured workspace-app labels, and omit unknown snapshots.

Show the last change in the autostop tooltip using usernames, up to three activity labels, and an additional-source count. Update the scheduling guide and generated API reference.

Implementation plan and decisions
  • Keep API response types and conversion here, separate from recording and persistence.
  • Preserve source identities and order, including different sources with equal labels. Render labels as text.
  • Keep wire-format, actor presentation, missing-snapshot, tooltip, and visual regression coverage in this layer. Consolidate fixtures and table cases while preserving every contract; persistence tests remain in feat: record the last workspace deadline change #31490.
  • Regenerate SDK, API documentation, and golden outputs from their sources.

Implements the presentation portion of the deadline-change RFC. Closes #17320.

Generated by Coder Agents on behalf of @EhabY.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@EhabY
EhabY marked this pull request as ready for review October 26, 2026 18:24
@EhabY
EhabY requested a review from nickvigilante as a code owner October 26, 2026 18:24

@code-asher code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!

Comment thread coderd/agentapi/apps.go Resolved
@EhabY
EhabY requested a review from code-asher October 27, 2026 00:29
@EhabY EhabY changed the title feat: explain which activity extended a workspace's autostop deadline feat: explain why a workspace's autostop deadline last changed Oct 27, 2026
@EhabY
EhabY force-pushed the feat/explain-workspace-keepalive branch from 0d0aa36 to 9326dc0 Compare October 27, 2026 14:12
code-asher
code-asher previously approved these changes Oct 27, 2026
Comment thread codersdk/workspacebuilds.go Resolved
@EhabY
EhabY marked this pull request as draft October 28, 2026 12:44
@EhabY
EhabY dismissed code-asher’s stale review October 28, 2026 12:45

Will re-eval the DB structure first

@EhabY
EhabY force-pushed the feat/explain-workspace-keepalive branch from 9326dc0 to 34d5bc1 Compare October 29, 2026 13:17
@EhabY EhabY changed the title feat: explain why a workspace's autostop deadline last changed feat: explain the last workspace deadline change Oct 29, 2026
@EhabY
EhabY requested a review from code-asher October 29, 2026 13:18
@EhabY
EhabY force-pushed the feat/explain-workspace-keepalive branch from 34d5bc1 to a7bad5b Compare October 29, 2026 14:48
@EhabY EhabY changed the title feat: explain the last workspace deadline change feat: explain deadline changes in the API and workspace tooltip Oct 29, 2026
@EhabY
EhabY changed the base branch from main to feat/workspace-deadline-recording October 29, 2026 14:49
@EhabY
EhabY added this pull request to stack #31492 October 29, 2026 14:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explain why workspace is kept alive

2 participants