Skip to content

feat: include the owner in the chat project ACL response - #31244

Merged
jaaydenh merged 1 commit into
mainfrom
chat-project-access/owner-in-acl
Nov 3, 2026
Merged

jaaydenh merged 1 commit into
mainfrom
chat-project-access/owner-in-acl

Conversation

@jaaydenh

@jaaydenh jaaydenh commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

The chat project ACL response now includes the project's owner, so the project page can show who owns a project to everyone who can read it.

GET /api/experimental/organizations/{organization}/chats/projects/{project}/acl returns a new owner field (MinimalUser). The owner is never in users, and GET /api/v2/users/{id} returns 404 to regular organization members, so project members and project admins currently see the owner as "Unknown". The handler loads the owner with a system-restricted context after the existing read and sharing-disabled checks, matching how it already loads shared users and groups.

TestChatProjectSharing/User and /Admin now check the owner as seen by the owner, a use sharee and an admin sharee, and that both sharees still get 404 from the users endpoint. Dogfood UAT on a dev deployment confirmed the field for all three callers, no owner data for callers without access (404), and the unchanged 403 when chat sharing is disabled.

Stack (merge bottom first):

@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T13:15:59.894127Z bcccfbd Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: bcccfbdcb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@linear-code

linear-code Bot commented Oct 26, 2026

Copy link
Copy Markdown

CODAGT-1464

@jaaydenh
jaaydenh marked this pull request as ready for review October 27, 2026 13:29

@nickvigilante nickvigilante left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

@jaaydenh
jaaydenh requested a review from f0ssel October 29, 2026 09:33
@jaaydenh
jaaydenh force-pushed the chat-project-access/owner-in-acl branch from 9c8d82e to b32f8d9 Compare November 3, 2026 15:18
@jaaydenh
jaaydenh merged commit 820689d into main Nov 3, 2026
31 of 32 checks passed
@jaaydenh
jaaydenh deleted the chat-project-access/owner-in-acl branch November 3, 2026 16:03
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants