Repository navigation
feat: include the owner in the chat project ACL response - #31244
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Oct 24, 2026
jaaydenh
marked this pull request as ready for review
October 27, 2026 13:29
f0ssel
approved these changes
Oct 30, 2026
jaaydenh
force-pushed
the
chat-project-access/owner-in-acl
branch
from
November 3, 2026 15:18
9c8d82e to
b32f8d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat project ACL response now includes the project's owner, so the project page can show who owns a project to everyone who can read it.
GET /api/experimental/organizations/{organization}/chats/projects/{project}/aclreturns a newownerfield (MinimalUser). The owner is never inusers, andGET /api/v2/users/{id}returns 404 to regular organization members, so project members and project admins currently see the owner as "Unknown". The handler loads the owner with a system-restricted context after the existing read and sharing-disabled checks, matching how it already loads shared users and groups.TestChatProjectSharing/Userand/Adminnow check the owner as seen by the owner, ausesharee and anadminsharee, and that both sharees still get 404 from the users endpoint. Dogfood UAT on a dev deployment confirmed the field for all three callers, no owner data for callers without access (404), and the unchanged 403 when chat sharing is disabled.Stack (merge bottom first):