Repository navigation
Conversation
…kills/skill-chips-composer
…roject-skills/settings-api
…lls/actions-site # Conflicts: # site/src/pages/AgentsPage/components/ProjectPage/ProjectSkillsDialog.tsx
…oject-skills/project-skills-details
… deleted-skill list refresh
… the composer is disabled
…roject-skills/settings-api
…roject-skills/invocation-api
…kills/skill-chips-composer
…ject-skills/skill-chips-transcript
…roject-skills/settings-api
…oject-skills/project-skills-details
…ll cap story and use canonical keys
…poser content first and fall back to its plain text
…file in its chip's remove label
…ject-skills/skill-chips-transcript # Conflicts: # site/src/pages/AgentsPage/components/ChatMessageInput/skillClipboard.ts
…e shared skill limit warning contract
…general draft without a project
…sting an unparseable composer payload
…roject-skills/settings-api
…roject-skills/invocation-api
…kills/skill-chips-composer
…ject-skills/skill-chips-transcript
…roject-skills/settings-api
…oject-skills/project-skills-details
The server located the key with a text prefix, so quoted or spaced keys stayed in stored content, and downloads then added a duplicate key that no parser accepts. Find the key through the YAML node tree, confirm the other fields survive, and let a false value turn automatic use back on. Downloads now check the parsed frontmatter before adding the marker.
…ills/automatic-use-site # Conflicts: # site/src/pages/AgentsPage/components/SkillsTable.test.tsx # site/src/pages/AgentsPage/utils/skills.test.ts # site/src/pages/AgentsPage/utils/skills.ts
The server removed the key on upload and only the browser added it back on download. The API returned files that other tools read as automatic, and a second YAML reader disagreed with the one workspace skills use. Store skill content as uploaded. Read the key with the shared workspacesdk reader, and make the content in every API response agree with model_invocable. Browser downloads now save that content unchanged.
Say which values Coder ignores and which it rejects, describe the returned file by what the reader gets, and note that a stored file whose key cannot be set is returned unchanged.
…skills/automatic-use-site The base now sets disable-model-invocation on the server in every API response, so the browser copy of that logic goes: skillFileContent, its tests, and the splitSkillMarkdown helper that only it needed. Download and Export all save the content the API returns.
…skills/automatic-use-site Brings in main's project skill display names. The skill editor keeps both the display name field and the shared automatic-use switch.
Addresses @ethanndickson's [review comment on #30882](#30882 (comment)): the same `SKILL.md` file could be manual-only in Claude Code and the project dialog but automatic in Coder, because the server and the browser each handled `disable-model-invocation` in their own way. The server now owns the key for personal, organization, and project skills: - When a create or update request leaves `model_invocable` unset, `disable-model-invocation: true` in the content turns automatic use off, and `false` turns it back on. The key is read with the function workspace skills use, so a file gets the same setting in both places. Only YAML booleans count, so a quoted `"true"` is ignored. - An explicit `model_invocable` in the request always wins. - New content without the key leaves the setting unchanged, so editing text never turns it back on. - Content is stored as uploaded. Every API response returns content whose key agrees with `model_invocable`: when the stored file says otherwise, the server replaces the value of the key or adds the key before the first one, and leaves every other byte alone. - **Download** and **Export all** save the content the API returns, so the browser no longer edits the file. `withDisabledModelInvocation` is removed. - An upload is rejected with a 400 when the key holds a value the server can't replace with a boolean, such as a list. A later change to `model_invocable` can then always reach the file. Two edges: - Adding the key makes the returned file about 30 bytes larger, so a file at the 64 KB upload limit can be too large to upload again. - A skill stored before the upload check with a value the server can't replace is returned as stored. Workspace skills already honor the key since #31147. #31160, the frontend PR on top of this one, adds the switch to the personal and organization skill editors. > Generated by an agent on behalf of the user --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Nick Vigilante <nickvigilante@users.noreply.github.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f461151705
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ethanndickson
left a comment
There was a problem hiding this comment.
one nit re: docs. could use some human love
| Importing a `SKILL.md` file that sets `disable-model-invocation: true` turns the switch off. | ||
| When you add a skill, importing a file without that line turns the switch back on. | ||
| When you edit a skill, it leaves the switch unchanged. |
There was a problem hiding this comment.
This reads weird. Not sure we even need to update docs here?
The API already accepts
model_invocablefor personal, organization, and project skills, but only the project skills dialog exposed it. Personal and organization skills could be made manual-only through the API, but the UI never showed it.SkillEditorDialog(personal and organization skill tables) gets the Agents can use it automatically switch, andSkillsTablesendsmodel_invocableon create and update.SkillsTableViewrows show a Manual only badge, matching the project skills dialog.disable-model-invocation: truefor manual-only skills, so this PR has no browser helper for it.SKILL.mdalways resets automatic use in create mode. An edit-mode import of a file withdisable-model-invocation: truenow turns the switch off instead of silently dropping the line, which matches the server rule in feat: honor disable-model-invocation in uploaded skill content #31159.Every skill editor dialog story now shows the new switch, so expect Pixel diffs on the
SkillsTableViewdialog stories.Depends on #31159.