Repository navigation
test(coderd/nats): use a random cluster port in TestPubsub/CloseIdempotent - #31056
Merged
Merged
Conversation
Collaborator
Author
|
@codex review
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ibetitsmike
marked this pull request as ready for review
October 20, 2026 17:43
ibetitsmike
enabled auto-merge (squash)
October 20, 2026 17:47
ThomasK33
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPubsub/CloseIdempotentincoderd/natsflakes in CI with "embedded nats server not ready within 10s" (for example intest-go-pg-17on main).It is the only subtest that calls
nats.Newwithnats.Options{}directly. WithClusterPortunset,buildServerOptionsfalls back to the fixed production cluster port 6222. Test packages run in parallel, andcliTestServer/SpammyLogsrunscoder server --cluster-host 127.0.0.1, which holds 127.0.0.1:6222. When the route listener cannot bind, nats-server logs nothing underNoLog, andReadyForConnectionswaits out the 10 sreadyTimeout.The fix gives the subtest
ClusterPort: natsserver.RANDOM_PORT, the option thenewPubsubhelper already sets for every other subtest. It is a one-line, test-only change.Testing
TestPubsub/CloseIdempotentfails after 10.01 s with the CI message.go test ./coderd/nats/...passes.go test ./coderd/nats/... -count=3andmake pre-commitpass.-count=5with no port held, and showed that an overlay whose secondClosereturns an error makes the subtest fail, so it still checks idempotentClose.Polish and the test audit made no changes, so both stayed inside the implementation diff (
coderd/nats/pubsub_test.go).Draft #30759 carries the same one-line edit as a drive-by, so whichever lands second merges cleanly.