Skip to content

ci: bump paralleltestctx to detect timeout contexts used through closures - #31039

Merged
ethanndickson merged 1 commit into
mainfrom
paralleltestctx-closure-ctx
Oct 20, 2026
Merged

ethanndickson merged 1 commit into
mainfrom
paralleltestctx-closure-ctx

Conversation

@ethanndickson

Copy link
Copy Markdown
Member

#31011 fixed a flake where a closure in TestProjectSkillQueries used the parent test's testutil.Context from parallel subtests. Once that deadline passed, the closure's require.NoError called FailNow on the parent t, which panics and takes down the whole coderd/database package. paralleltestctx only checked direct references to the context, so it missed this. coder/paralleltestctx#6 now follows calls to local closures too.

This pins paralleltestctx to the current main commit, as there's no tag yet. That commit also brings in the outer variable reassignment check from coder/paralleltestctx#4 and the x/tools bump from coder/paralleltestctx#5. The closure check flagged the loadPrompt helper in TestMediaToolResultRoundTrip, so it now makes its own context from the subtest's t. The TestGraph and TestRuntimeAudit fixes for the outer variable check are the same as in #30288, so that PR only needs to repin.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T02:12:41.793847Z 29cb369 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ethanndickson
ethanndickson merged commit 86ea5d4 into main Oct 20, 2026
52 of 53 checks passed
@ethanndickson
ethanndickson deleted the paralleltestctx-closure-ctx branch October 20, 2026 04:41
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants