Repository navigation
ci: bump paralleltestctx to detect timeout contexts used through closures - #31039
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jaaydenh
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31011 fixed a flake where a closure in
TestProjectSkillQueriesused the parent test'stestutil.Contextfrom parallel subtests. Once that deadline passed, the closure'srequire.NoErrorcalledFailNowon the parentt, which panics and takes down the wholecoderd/databasepackage.paralleltestctxonly checked direct references to the context, so it missed this. coder/paralleltestctx#6 now follows calls to local closures too.This pins
paralleltestctxto the currentmaincommit, as there's no tag yet. That commit also brings in the outer variable reassignment check from coder/paralleltestctx#4 and thex/toolsbump from coder/paralleltestctx#5. The closure check flagged theloadPrompthelper inTestMediaToolResultRoundTrip, so it now makes its own context from the subtest'st. TheTestGraphandTestRuntimeAuditfixes for the outer variable check are the same as in #30288, so that PR only needs to repin.