Repository navigation
test(coderd/database): use subtest context in TestProjectSkillQueries - #31011
Merged
Merged
Conversation
The parallel subtests used the parent test's WaitLong context and called require.NoError on the parent *testing.T through the as helper. Parallel subtests only start after the parent returns and a parallel slot frees up, so on slow runners the shared deadline had already expired. The resulting FailNow on the parent from a child goroutine panicked and aborted the whole coderd/database package. Pass the caller's t and ctx into as, and give each subtest its own context created after t.Parallel(). Fixes CODAGT-1424
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jaaydenh
marked this pull request as ready for review
October 19, 2026 08:50
ibetitsmike
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestProjectSkillQueriescrashed the wholecoderd/databasepackage on macOS and Windows in nightly-gauntlet (run) withpanic: test executed panic(nil) or runtime.Goexit.Its parallel subtests used the parent's
WaitLongcontext and calledrequire.NoErroron the parent*testing.Tthrough theashelper. Parallel subtests only start after the parent returns and a-parallelslot frees up, so on slow runners the shared deadline had already expired (get authorization user roles: context deadline exceeded). CallingFailNowon the parent from a child goroutine then panicked and aborted the package, leaving hundreds of(unknown)failures.asnow takes the caller'standctx, and each subtest creates its own context aftert.Parallel().Fixes CODAGT-1424