Skip to content

feat(site/src): edit chat project templates from the project details - #30898

Open
jaaydenh wants to merge 84 commits into
chat-project-templates/templates-dialogfrom
chat-project-templates/project-page
Open

jaaydenh wants to merge 84 commits into
chat-project-templates/templates-dialogfrom
chat-project-templates/project-page

Conversation

@jaaydenh

@jaaydenh jaaydenh commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Moves editing a chat project's templates out of the Edit project dialog and into the project page's Details section.

  • Details gains a Templates row that shows how many attached templates you can access, prefixed with "Limited to" when the project limits its chats. The count is a link-style button with a pen icon that opens the Edit templates dialog from feat(site): add a dialog that edits a chat project's templates #32375. Without update permission the count is plain text.
  • Attached templates you can't access appear only as a separate "N hidden" count, with a note that a template admin or organization admin can give you access. The dialog shows the same note under the templates field and counts them toward the limit warning.
  • Saving sends only what changed: it attaches the added templates, then updates the limit and default template in one PATCH, then detaches the removed templates. Templates you can't see are never detached. A 404 from detaching counts as done, any other failure stops the save, and the steps before it stay saved.
  • Closing the dialog returns focus to the edit button, or to the count when a refresh removed your update permission.

Both screenshots are from a project admin who cannot access one of the attached templates.

Details Edit templates
Templates row in Details Edit templates dialog

What to look at: the test for the 404 path of the save lands in #32377, not here. It waits on the number of project requests, which includes the request of the pre-save check that #32377 adds, and tests moved between the PRs unchanged.

This PR used to hold more. To keep each PR small, the rest moved unchanged to other PRs of the stack: the ProjectEditConflictAlert extraction to #32371, the MultiSelectCombobox first-render fix to #32372, the dialog itself to #32375, refreshing and conflict handling to #32376, the check right before saving to #32377, the cleanup of stale defaults to #32378, and the documentation to #32379.

Stack (merge top to bottom):

The project page's Details section gains a Templates row that shows how
many templates the project allows and opens a dialog to edit them and
their defaults.

MultiSelectCombobox now shows a value passed on its first render.
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T15:05:17.423099Z 59aa7f0 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27692b6332

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5c4fbbde0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jaaydenh
jaaydenh added this pull request to stack #30892 October 19, 2026 14:27
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 384312a904

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…editing without update permission and cover refetch errors in stories
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 481a4a1783

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…f ineligible templates and restore focus after the templates dialog
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a22888453c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@linear-code

linear-code Bot commented Oct 21, 2026

Copy link
Copy Markdown

CODAGT-1437

# Conflicts:
#	site/src/pages/AgentsPage/components/ProjectPage/ProjectDetailsPanel.tsx
#	site/src/pages/AgentsPage/components/ProjectPage/ProjectDetailsPanelView.stories.tsx
#	site/src/pages/AgentsPage/components/ProjectPage/ProjectDetailsPanelView.tsx
…s/project-page

# Conflicts:
#	site/src/pages/AgentsPage/components/ChatsSidebar/dialogs/ChatProjectTemplatesFields.tsx
…eters

The default parameter fields now come from the template's evaluation and
carry its constraints, so the dialog's form skips native validation: a
required parameter without a project default no longer blocks Save.

The dialog's tests and stories read the parameters from the evaluation,
and the projects page documents the new fields.
The Edit templates dialog tests found the parameter fields through the
rich-parameter fixtures, which only worked because the preview fixtures
copy their names.
jaaydenh added a commit that referenced this pull request Nov 17, 2026
Adds the database layer for attaching workspace templates to chat
projects: the schema, the queries, their authorization, and the audit
type. Nothing calls the new queries yet, and the existing create and
update handlers pass the new parameters unset. The API, the limit's
enforcement, and the agent tools follow in the PRs above.

- Attachments live in a `chat_project_templates` table (`project_id`,
`template_id`, `created_by`, `created_at`), deleted with the project or
the template. `chat_projects` gains `limit_templates` (default `false`),
`default_template_id`, `default_template_version_preset_id`, and
`default_parameters jsonb`. A project stores a default preset or default
parameter values, not both.
- `InsertChatProjectTemplates` needs project `update` and `use` on every
template. It skips templates that are already attached, and templates
outside the project's organization, so an attachment never crosses
organizations. `DeleteChatProjectTemplate` needs project `update` and
template `read`, and clears the project's default when it detaches the
default template. Both checks are in dbauthz.
- `GetChatProjectTemplatesByProjectIDs` is authorized through the
project, and leaves out deleted, deprecated, and agent-disabled
templates. It does not check the caller's access to each template, so
callers do that before they expose one.
- `UpdateChatProjectByID` changes the template settings only when the
request sets them, so an update that omits them cannot write back a
stale snapshot.
- `AuditableChatProjectTemplates` is the audit form of a project's
attached templates, logged as a write to the project. The new
`chat_projects` columns are tracked in the project's own audit diff,
with the default parameter values masked because they may hold
credentials.

**NOTE**: the migration adds one table and four columns and changes no
existing rows. Existing projects keep unlimited template access.

Stack (merge top to bottom):
- #32309 👈
- #30754
- #32310
- #30755
- #30756
- #30898
…s to later pull requests

This branch keeps the Templates row of the project details, the save
that attaches, updates, and detaches, and the hidden templates count.
The dialog itself now comes from the branch below. Refreshing and
conflict handling, the check right before saving, the cleanup of stale
defaults, and the documentation move unchanged to the four branches
above, so each can be reviewed on its own.
jaaydenh added a commit that referenced this pull request Nov 18, 2026
Adds the API for attaching workspace templates to a chat project, on the
schema and queries in #32309. A project can attach templates, turn on a
limit that restricts its chats to them, and set a default template with
either a default preset or default parameter values. Attaching a
template never grants access to it: every reader is checked against the
template's own sharing. This PR stores and returns `limit_templates`;
#32310 enforces it.

- The limit is opt-in. `limit_templates` is off unless a request turns
it on, which is what every existing project gets.
- Templates are attached and detached one at a time with `PUT` and
`DELETE /chats/projects/{project}/templates/{template}`, so a caller
never replaces a list they can only partly see. Attaching needs project
`update` and template `use`. Detaching needs project `update` and
template `read`, and a template the caller cannot read is reported as
not found. `POST /chats/projects` accepts `template_ids`,
`limit_templates`, and `default_template` for the new project.
- `PATCH /chats/projects/{project}` sets `limit_templates` and
`default_template`, and no longer changes which templates are attached.
The default must be an attached template the caller can read, and its
preset must belong to the template's active version. Default parameter
names and values are checked against that version for templates on the
classic parameter flow; dynamic parameters are checked when a workspace
is built. Detaching the default template clears the default.
- Project responses list only the attached templates the caller can
read, as `templates`, and count the rest as `hidden_template_count`.
`default_template` is omitted when the caller cannot read it. Deleted,
deprecated, and agent-disabled templates are left out and are not
counted as hidden.
- Editing uses `chat_project:update`, which the project owner and the
project `admin` ACL role have.
- Attaching and detaching are audited as writes to the project, with the
template list before and after, including the templates attached while
creating a project. Changes to `limit_templates` and the default
template are part of the project's own audit diff.

Not included: showing which project members lack access to an attached
template, and MCP server attachments.

Stack (merge top to bottom):
- #32309
- #30754 👈
- #32310
- #30755
- #32371
- #32372
- #30756
- #32373
- #32374
- #32375
- #30898
- #32376
- #32377
- #32378
- #32379

This branch was previously deployed

1 inactive (outdated) deployment
docs-preview — efb75382 Deployed Nov 13, 2026 by jaaydenh via deploy #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant