Repository navigation
feat: move chats between projects through the chat update API - #30894
Merged
Merged
Conversation
chatd gains MoveChatToProject, which sets the project of a root chat. Its subagent chats follow because they use the project of the root. The chatstate machine gets a SetProject transition, allowed only from W, E0 and E1, like SetArchived. SetFamilyProject locks the root row before its subagents, in the same order as archiving, so a busy family gets ErrTransitionNotAllowed and a move never overlaps a step. A move to the project the chat is already in changes nothing, even while the chat runs. After the commit, chatd publishes a project_change watch event for each chat of the family. A root chat outside a project now has an empty memory index, so a chat that leaves its project, or whose project is deleted, gets the memories it saw removed at its next turn start.
PATCH /api/v2/chats/{chat} now accepts project_id. A UUID moves an idle
root chat into a project of its owner and organization; uuid.Nil removes
it from its project. The project checks are the ones of chat creation,
now shared by validateChatProjectSelection.
A project that the chat's owner does not own gives 404 even for an
admin, so an admin cannot put a member's chat into another user's
project and expose its memory. A child chat, an archived chat or a
disabled experiment gives 400, and a busy family gives 409. The move is
the last write of the request, so a refused move keeps the earlier
writes, as a refused archive does.
This was referenced Oct 16, 2026
ibetitsmike
marked this pull request as ready for review
October 16, 2026 14:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ThomasK33
approved these changes
Oct 19, 2026
Add the SetProject transition to the transition list and the execution state diagram, note that a root chat's project can change after creation, and describe how a moved chat's memory index is brought up to date at its next turn.
The PATCH /api/v2/chats/{chat} section said the endpoint emits no state
transitions unless the request changes archived. A project_id change now
applies SetProject to the chat family, so list its supported states and
refusals.
Brings in origin/main through mike/move-chats-chatd. Chat creation on main now checks project access with chatd.ChatProjectUsableBy, so validateChatProjectSelection uses that check for both creation and moves.
A move accepts the same projects as chat creation, which now include projects shared with the chat's owner. Extend the owner-check test to share the project and move the chat, and describe the rule on UpdateChatRequest.ProjectID.
ibetitsmike
added a commit
that referenced
this pull request
Oct 19, 2026
chatd can now move a root chat, together with its subagent chats, into a project, to another project, or out of its project. Nothing calls this yet. #30894 adds the API. **Stack** (moving chats between projects, bottom first): 1. **This PR**: the move in chatd 2. #30894: `PATCH /api/v2/chats/{chat}` takes `project_id` 3. #30895: **Move to project** in the chat menu 4. #30795: drag a chat onto a project folder in the sidebar **Why:** today a chat keeps the project it was created with. A move must follow the family rules of archiving, because a step that runs during a move would still have the memory tools of the old project. - `chatstate.Tx.SetProject` runs only from W, E0 and E1, like `SetArchived`. `SetFamilyProject()` locks the root row before its subagents, in the same order as archiving, so a busy family gets `ErrTransitionNotAllowed` and nothing changes. - A move to the project the chat is already in changes nothing, even while the chat runs. The check reads the locked root row, so it waits for a move that is still in flight. - Only the root row stores `project_id`, and subagents use the project of the root. After the commit, chatd publishes a new `project_change` watch event for each chat of the family. The move keeps `updated_at`, so lists keep their order. - A root chat outside a project now has an empty memory index. When a chat leaves its project, or its project is deleted, its next turn start commits one memory index update that removes the memories the model saw there. **What to scrutinize:** the lock order and the same-project check under the lock in `SetFamilyProject()` (`chatstate/family.go`), the turn-start condition in `memoryIndexMessage()` (`memory.go`), and whether the `ARCHITECTURE.md` text matches them. **Generated** (`make gen`): `queries.sql.go`, `querier.go`, `dbmock` and `dbmetrics` come from `queries/chats.sql`. `coderd/apidoc`, `docs/reference/api/schemas.md` and `typesGenerated.ts` come from the new watch event kind, which is also why two `chats.test.ts` fixtures gain `project_change: false`. **Architecture doc:** `coderd/x/chatd/ARCHITECTURE.md` lists `SetProject` among the transitions and in the execution state diagram (W, E0 and E1 back to themselves). It also says that a root chat's project can change after creation, and that a moved chat's next turn starts with a memory index update from the old project to the new one. ## Testing - `make pre-commit` passes. `go test` passes for `coderd/x/chatd/chatstate`, `coderd/database/dbauthz` (`TestMethodTestSuite`) and the chatd memory tests. - `TestSetFamilyProjectLocksRootFirst` fails with 55P03 when a subagent row is locked first. `TestSetFamilyProjectKeepsTheCurrentProject` covers the same-project move during a run. The transition matrix test gains `SetProject` cases for W, E0 and E1. - `TestMovedChatUsesNewProject` runs two real turns around a move: the second turn uses the instructions and memories of the new project, and `OutOfProject` fails without the memory index removal. > Xum opened this PR on behalf of @ibetitsmike.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATCH /api/v2/chats/{chat}now takesproject_id. A project ID moves the chat into that project, anduuid.Nilremoves it from its project.Stack (moving chats between projects, bottom first):
project_idWhy: #30893 can move a chat family, and the UI layers above need an endpoint to call.
validateChatProjectSelection(), which this PR extracts frompostChats()without a change in behavior.chatd.ChatProjectUsableBy, the check that chat creation uses since feat: add chat project sharing API #30439). So an admin cannot put a member's chat into a project that the member has no access to and expose its memory.chat-projectsexperiment gives 400. A family that is not idle gives 409 ("Cannot move an active chat. Interrupt or wait for the chat to finish first."). A project deleted between the check and the move gives 404.patchChat(), so a refused move keeps the earlier writes of the same request, as a refused archive does.What to scrutinize: the access check in
validateChatProjectSelection()and the order of the refusals inpatchChat()(coderd/exp_chats.go).Architecture doc: the
PATCH /api/v2/chats/{chat}section ofcoderd/x/chatd/ARCHITECTURE.mdlists theSetProjectstates of a move and its refusals, and no longer says that only anarchivedchange emits transitions.Generated (
make gen):coderd/apidoc,docs/reference/api/chats.md,docs/reference/api/schemas.mdandtypesGenerated.tscome fromUpdateChatRequest.ProjectIDincodersdk/chats.go.Testing
make pre-commitpasses, and so doesgo test ./coderd -run TestPatchChatProject(14 subtests).TestPatchChatProject/AnotherOwnersProjectgets 404 for another user's project, then moves the chat after the project is shared with the chat's owner. It fails without the access check, and also with an owner-only check.MoveBackWaitsForAPendingMoveends in the wrong project when the handler skips the move before the lock.ActiveFamilyReturnsConflictchecks the 409 for a running, interrupting or action-waiting root and for a running subagent.PublishesProjectChangeandAuditsTheMovecover the watch event and the audit entry.