Skip to content

feat: move chats between projects through the chat update API - #30894

Merged
ibetitsmike merged 9 commits into
mainfrom
mike/move-chats-api
Oct 19, 2026
Merged

ibetitsmike merged 9 commits into
mainfrom
mike/move-chats-api

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

PATCH /api/v2/chats/{chat} now takes project_id. A project ID moves the chat into that project, and uuid.Nil removes it from its project.

Stack (moving chats between projects, bottom first):

  1. feat: move a chat family between projects in chatd #30893: the move in chatd
  2. This PR: the chat update API takes project_id
  3. feat(site/src): move chats between projects from the chat menu #30895: Move to project in the chat menu
  4. feat(site): drag chats onto project folders in the sidebar #30795: drag a chat onto a project folder in the sidebar

Why: #30893 can move a chat family, and the UI layers above need an endpoint to call.

  • A move accepts the same projects as chat creation, through validateChatProjectSelection(), which this PR extracts from postChats() without a change in behavior.
  • A project that the chat's owner cannot use gives 404, even for an admin. The owner must own the project or hold a grant on it (chatd.ChatProjectUsableBy, the check that chat creation uses since feat: add chat project sharing API #30439). So an admin cannot put a member's chat into a project that the member has no access to and expose its memory.
  • A child chat, an archived chat or a disabled chat-projects experiment gives 400. A family that is not idle gives 409 ("Cannot move an active chat. Interrupt or wait for the chat to finish first."). A project deleted between the check and the move gives 404.
  • The move is the last write in patchChat(), so a refused move keeps the earlier writes of the same request, as a refused archive does.

What to scrutinize: the access check in validateChatProjectSelection() and the order of the refusals in patchChat() (coderd/exp_chats.go).

Architecture doc: the PATCH /api/v2/chats/{chat} section of coderd/x/chatd/ARCHITECTURE.md lists the SetProject states of a move and its refusals, and no longer says that only an archived change emits transitions.

Generated (make gen): coderd/apidoc, docs/reference/api/chats.md, docs/reference/api/schemas.md and typesGenerated.ts come from UpdateChatRequest.ProjectID in codersdk/chats.go.

Testing

  • make pre-commit passes, and so does go test ./coderd -run TestPatchChatProject (14 subtests).
  • TestPatchChatProject/AnotherOwnersProject gets 404 for another user's project, then moves the chat after the project is shared with the chat's owner. It fails without the access check, and also with an owner-only check. MoveBackWaitsForAPendingMove ends in the wrong project when the handler skips the move before the lock. ActiveFamilyReturnsConflict checks the 409 for a running, interrupting or action-waiting root and for a running subagent. PublishesProjectChange and AuditsTheMove cover the watch event and the audit entry.
  • Untested: the 404 when the project is deleted between the check and the move.

Xum opened this PR on behalf of @ibetitsmike.

chatd gains MoveChatToProject, which sets the project of a root chat.
Its subagent chats follow because they use the project of the root.

The chatstate machine gets a SetProject transition, allowed only from
W, E0 and E1, like SetArchived. SetFamilyProject locks the root row
before its subagents, in the same order as archiving, so a busy family
gets ErrTransitionNotAllowed and a move never overlaps a step. A move to
the project the chat is already in changes nothing, even while the chat
runs. After the commit, chatd publishes a project_change watch event for
each chat of the family.

A root chat outside a project now has an empty memory index, so a chat
that leaves its project, or whose project is deleted, gets the memories
it saw removed at its next turn start.
PATCH /api/v2/chats/{chat} now accepts project_id. A UUID moves an idle
root chat into a project of its owner and organization; uuid.Nil removes
it from its project. The project checks are the ones of chat creation,
now shared by validateChatProjectSelection.

A project that the chat's owner does not own gives 404 even for an
admin, so an admin cannot put a member's chat into another user's
project and expose its memory. A child chat, an archived chat or a
disabled experiment gives 400, and a busy family gives 409. The move is
the last write of the request, so a refused move keeps the earlier
writes, as a refused archive does.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T14:04:51.785599Z 15a49ca Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nickvigilante nickvigilante left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

@pr-queue-manager
pr-queue-manager Bot requested a review from ThomasK33 October 16, 2026 14:21
Add the SetProject transition to the transition list and the execution
state diagram, note that a root chat's project can change after
creation, and describe how a moved chat's memory index is brought up to
date at its next turn.
The PATCH /api/v2/chats/{chat} section said the endpoint emits no state
transitions unless the request changes archived. A project_id change now
applies SetProject to the chat family, so list its supported states and
refusals.
Brings in origin/main through mike/move-chats-chatd. Chat creation on
main now checks project access with chatd.ChatProjectUsableBy, so
validateChatProjectSelection uses that check for both creation and
moves.
A move accepts the same projects as chat creation, which now include
projects shared with the chat's owner. Extend the owner-check test to
share the project and move the chat, and describe the rule on
UpdateChatRequest.ProjectID.
Base automatically changed from mike/move-chats-chatd to main October 19, 2026 12:38
ibetitsmike added a commit that referenced this pull request Oct 19, 2026
chatd can now move a root chat, together with its subagent chats, into a
project, to another project, or out of its project. Nothing calls this
yet. #30894 adds the API.

**Stack** (moving chats between projects, bottom first):
1. **This PR**: the move in chatd
2. #30894: `PATCH /api/v2/chats/{chat}` takes `project_id`
3. #30895: **Move to project** in the chat menu
4. #30795: drag a chat onto a project folder in the sidebar

**Why:** today a chat keeps the project it was created with. A move must
follow the family rules of archiving, because a step that runs during a
move would still have the memory tools of the old project.

- `chatstate.Tx.SetProject` runs only from W, E0 and E1, like
`SetArchived`. `SetFamilyProject()` locks the root row before its
subagents, in the same order as archiving, so a busy family gets
`ErrTransitionNotAllowed` and nothing changes.
- A move to the project the chat is already in changes nothing, even
while the chat runs. The check reads the locked root row, so it waits
for a move that is still in flight.
- Only the root row stores `project_id`, and subagents use the project
of the root. After the commit, chatd publishes a new `project_change`
watch event for each chat of the family. The move keeps `updated_at`, so
lists keep their order.
- A root chat outside a project now has an empty memory index. When a
chat leaves its project, or its project is deleted, its next turn start
commits one memory index update that removes the memories the model saw
there.

**What to scrutinize:** the lock order and the same-project check under
the lock in `SetFamilyProject()` (`chatstate/family.go`), the turn-start
condition in `memoryIndexMessage()` (`memory.go`), and whether the
`ARCHITECTURE.md` text matches them.

**Generated** (`make gen`): `queries.sql.go`, `querier.go`, `dbmock` and
`dbmetrics` come from `queries/chats.sql`. `coderd/apidoc`,
`docs/reference/api/schemas.md` and `typesGenerated.ts` come from the
new watch event kind, which is also why two `chats.test.ts` fixtures
gain `project_change: false`.

**Architecture doc:** `coderd/x/chatd/ARCHITECTURE.md` lists
`SetProject` among the transitions and in the execution state diagram
(W, E0 and E1 back to themselves). It also says that a root chat's
project can change after creation, and that a moved chat's next turn
starts with a memory index update from the old project to the new one.

## Testing

- `make pre-commit` passes. `go test` passes for
`coderd/x/chatd/chatstate`, `coderd/database/dbauthz`
(`TestMethodTestSuite`) and the chatd memory tests.
- `TestSetFamilyProjectLocksRootFirst` fails with 55P03 when a subagent
row is locked first. `TestSetFamilyProjectKeepsTheCurrentProject` covers
the same-project move during a run. The transition matrix test gains
`SetProject` cases for W, E0 and E1.
- `TestMovedChatUsesNewProject` runs two real turns around a move: the
second turn uses the instructions and memories of the new project, and
`OutOfProject` fails without the memory index removal.

> Xum opened this PR on behalf of @ibetitsmike.
@ibetitsmike
ibetitsmike merged commit dfdd6a5 into main Oct 19, 2026
33 of 34 checks passed
@ibetitsmike
ibetitsmike deleted the mike/move-chats-api branch October 19, 2026 14:01
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants