Skip to content

ci(.github/workflows): remove nix from dogfood image matrix (backport 2.34) - #30858

Merged
droopy4096 merged 2 commits into
release/2.34from
dm-fix-nix-2.34
Oct 15, 2026
Merged

droopy4096 merged 2 commits into
release/2.34from
dm-fix-nix-2.34

Conversation

@droopy4096

@droopy4096 droopy4096 commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Removes the nix dev image from .github/workflows/dogfood.yaml on release/2.34, aligning it with release/2.35 and later (["22.04", "26.04"]). Tracked in ENT-214.

Why

build_image (nix) fails on every release/2.34 PR that triggers the dogfood workflow (e.g. #30811):

error: cannot download google-chrome-stable_143.0.7499.169-1_amd64.deb from any mirror (HTTP 404)

The nix dev image includes google-chrome from the nixos-25.05 nixpkgs pinned in this branch's flake.lock. Google only serves recent Chrome builds, so the pinned .deb is gone. main removed the nix image in #26022 after 2.34 was cut, so only this branch still builds it. Bumping nixpkgs instead would change many packages on an old release branch, and the Chrome pin would go stale again.

Changes

.github/workflows/dogfood.yaml only, mirroring the workflow part of #26022:

  • Drop nix from the build_image matrix.
  • Remove the nix-only steps: Nix install, cache-nix-action, nix build .#dev_image, and the codercom/oss-dogfood-nix push.
  • Drop the matrix.image-version != 'nix' guards, which are now always true.
  • Drop the flake.nix / flake.lock path triggers, since no job in this workflow uses the flake anymore.
  • Update comments that mentioned the nix image.

Not touched, to keep the backport small: flake.nix (dev_image output), nix/docker.nix, and the nix image option in dogfood/coder/main.tf. None of them is used by CI after this change.

Notes

@droopy4096
droopy4096 changed the base branch from main to release/2.34 October 15, 2026 15:56
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @droopy4096!

This PR is targeting the release/2.34 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

@droopy4096 droopy4096 changed the title Dm fix nix 2.34 Remove Nix from matrix in 2.34 Oct 15, 2026
@linear-code

linear-code Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

ENT-214

ENT-215

@droopy4096 droopy4096 changed the title Remove Nix from matrix in 2.34 ci(.github/workflows): remove nix from dogfood image matrix (backport 2.34) Oct 15, 2026
@coder
coder Bot requested a review from denisra October 15, 2026 16:12
@denisra

denisra commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Not a blocker, but we are not using chromatic anymore, so we'll need a separate PR to drop it from every release branch where it's still active. This is just a note for us to follow up on later.

@droopy4096
droopy4096 merged commit 879323c into release/2.34 Oct 15, 2026
37 of 40 checks passed
@droopy4096
droopy4096 deleted the dm-fix-nix-2.34 branch October 15, 2026 17:56
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants