Repository navigation
ci(.github/workflows): remove nix from dogfood image matrix (backport 2.34) - #30858
Merged
Merged
Conversation
droopy4096
requested review from
a team,
Emyrk,
ibetitsmike,
jdomeracki-coder,
johnstcn,
nickvigilante and
spikecurtis
as code owners
October 15, 2026 15:55
Contributor
|
👋 Hey @droopy4096! This PR is targeting the Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format: If this is not a bug fix, it likely should not target a release branch. |
Collaborator
|
Not a blocker, but we are not using chromatic anymore, so we'll need a separate PR to drop it from every release branch where it's still active. This is just a note for us to follow up on later. |
denisra
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the nix dev image from
.github/workflows/dogfood.yamlonrelease/2.34, aligning it withrelease/2.35and later (["22.04", "26.04"]). Tracked in ENT-214.Why
build_image (nix)fails on everyrelease/2.34PR that triggers the dogfood workflow (e.g. #30811):error: cannot download google-chrome-stable_143.0.7499.169-1_amd64.deb from any mirror(HTTP 404)The nix dev image includes
google-chromefrom thenixos-25.05nixpkgs pinned in this branch'sflake.lock. Google only serves recent Chrome builds, so the pinned.debis gone.mainremoved the nix image in #26022 after 2.34 was cut, so only this branch still builds it. Bumping nixpkgs instead would change many packages on an old release branch, and the Chrome pin would go stale again.Changes
.github/workflows/dogfood.yamlonly, mirroring the workflow part of #26022:nixfrom thebuild_imagematrix.cache-nix-action,nix build .#dev_image, and thecodercom/oss-dogfood-nixpush.matrix.image-version != 'nix'guards, which are now always true.flake.nix/flake.lockpath triggers, since no job in this workflow uses the flake anymore.Not touched, to keep the backport small:
flake.nix(dev_imageoutput),nix/docker.nix, and the nix image option indogfood/coder/main.tf. None of them is used by CI after this change.Notes
Analyze PR for Documentation Updates Neededfails here for an unrelated reason (outdatedagents-chat-actionpin, fixed by ci: bump agents-chat-action to v0.5.1 in doc-check (backport 2.34) #30850 / ENT-212).chromaticfails on allrelease/2.34PRs ("No app with code ... found"), also unrelated.