Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
2ac1248
feat: add project skill queries and authorization
jaaydenh Oct 15, 2026
836c956
refactor(coderd/database): share chat project config authorization he…
jaaydenh Oct 15, 2026
7bc17ba
test(coderd/database): assert project skill reads stay scoped to thei…
jaaydenh Oct 15, 2026
1c9e8f1
feat: add project skill API routes
jaaydenh Oct 15, 2026
d623418
chore(coderd): clarify chat project skill limit comment
jaaydenh Oct 15, 2026
dda45bc
feat(coderd/x): load project skills in chats
jaaydenh Oct 15, 2026
27c808d
feat(site): list project skills in the chat slash menu
jaaydenh Oct 15, 2026
009432c
refactor(site/src/pages/AgentsPage): share stored skill source loadin…
jaaydenh Oct 15, 2026
a3a2f5d
refactor(site/src/pages/AgentsPage/components/ChatMessageInput): simp…
jaaydenh Oct 15, 2026
23a5168
refactor(site/src/pages/AgentsPage): name stored skill source flags a…
jaaydenh Oct 15, 2026
5533023
refactor(site/src/pages/AgentsPage/components): clarify skill source …
jaaydenh Oct 15, 2026
681b374
test: cover project skill loader and gating gaps
jaaydenh Oct 15, 2026
2a72a92
test(site/src/pages/AgentsPage/components): assert the project skills…
jaaydenh Oct 15, 2026
26deda5
fix(site/src/pages/AgentsPage): use the root chat's project for subag…
jaaydenh Oct 15, 2026
549a030
fix(site/src/pages/AgentsPage): keep inherited project skills pending…
jaaydenh Oct 15, 2026
7b6c3e3
test(site/src/pages/AgentsPage/components): restore Range geometry st…
jaaydenh Oct 15, 2026
a14b495
refactor(site/src/pages/AgentsPage): extract SkillEditorForm and shar…
jaaydenh Oct 15, 2026
e1a4429
fix(site/src/pages/AgentsPage/components): keep the edited skill name…
jaaydenh Oct 15, 2026
85fcc37
refactor(site/src/pages/AgentsPage/components): drop a JSDoc that res…
jaaydenh Oct 15, 2026
553df7e
refactor(site/src/pages/AgentsPage/components): drop comments that re…
jaaydenh Oct 15, 2026
e6af784
Merge remote-tracking branch 'origin/main' into HEAD
jaaydenh Oct 16, 2026
ebb0776
fix(coderd/database/migrations): renumber chat project skill audit mi…
jaaydenh Oct 16, 2026
2ea1fca
Merge branch 'chat-project-skills/queries' into chat-project-skills/api
jaaydenh Oct 16, 2026
f317b07
Merge branch 'chat-project-skills/api' into chat-project-skills/chatd
jaaydenh Oct 16, 2026
958d217
Merge branch 'chat-project-skills/chatd' into chat-project-skills/sub…
jaaydenh Oct 16, 2026
483db17
Merge branch 'chat-project-skills/subagent-project' into chat-project…
jaaydenh Oct 16, 2026
f010477
chore(coderd): remove non-essential project skill comments
jaaydenh Oct 18, 2026
cbb4bf7
Merge remote-tracking branch 'origin/main' into rs-queries
jaaydenh Oct 18, 2026
1799827
fix(coderd/database/migrations): renumber chat project skill audit mi…
jaaydenh Oct 18, 2026
d1c3934
Merge branch 'rs-queries' into rs-api
jaaydenh Oct 18, 2026
a63de89
Merge branch 'rs-api' into rs-chatd
jaaydenh Oct 18, 2026
8e1aa52
feat: add project skill API routes
jaaydenh Oct 15, 2026
34c10cd
chore(coderd): clarify chat project skill limit comment
jaaydenh Oct 15, 2026
c20a345
Merge branch 'chat-project-skills/api' into chat-project-skills/chatd
jaaydenh Oct 18, 2026
ec1b625
Merge remote-tracking branch 'origin/main' into chat-project-skills/c…
jaaydenh Oct 18, 2026
c39c1e0
Merge branch 'chat-project-skills/chatd' into chat-project-skills/sub…
jaaydenh Oct 18, 2026
e848b00
Merge branch 'chat-project-skills/subagent-project' into chat-project…
jaaydenh Oct 18, 2026
52ba82d
Merge remote-tracking branch 'origin/main' into skills-chatd-fix
jaaydenh Oct 20, 2026
1c06855
chore: update architecture.md
jaaydenh Oct 20, 2026
0c938f1
fix: gate project skills on project usability and fail open in the co…
jaaydenh Oct 20, 2026
379ae2e
fix(site/src/pages/AgentsPage): keep loaded project skills after a fa…
jaaydenh Oct 20, 2026
ee7773e
Merge remote-tracking branch 'origin/chat-project-skills/chatd' into …
jaaydenh Oct 20, 2026
8288725
docs(site/src/pages/AgentsPage/components/ChatMessageInput): clarify …
jaaydenh Oct 20, 2026
894beaf
fix(site/src): count only lost project access as no project skills
jaaydenh Oct 20, 2026
019f52f
fix(site/src): let lost project access override cached project skills
jaaydenh Oct 20, 2026
2964653
test(site/src/pages/AgentsPage/components/ChatMessageInput): cover lo…
jaaydenh Oct 20, 2026
b0a3bbc
revert(site/src/pages/AgentsPage): drop the root-chat project fallbac…
jaaydenh Oct 20, 2026
b1e7cf2
Merge remote-tracking branch 'origin/chat-project-skills/chatd' into …
jaaydenh Oct 20, 2026
89a2e9a
fix(site/src): hide project skills the caller's chats cannot use
jaaydenh Oct 20, 2026
9231e4e
fix(site/src/api/queries): treat a cached project list as unknown unt…
jaaydenh Oct 20, 2026
17ba94d
Merge remote-tracking branch 'origin/main' into wyav/sk-chatd
jaaydenh Oct 20, 2026
b79ed20
Merge branch 'wyav/sk-chatd' into wyav/sk-skill-editor-form
jaaydenh Oct 20, 2026
90de6c8
refactor(coderd/x/chatd): remove the unused resolveProjectInstructions
jaaydenh Oct 21, 2026
e9117ba
chore: update architecture.md
jaaydenh Oct 21, 2026
f83fb91
Merge branch 'chat-project-skills/chatd' of https://github.com/coder/…
jaaydenh Oct 21, 2026
e9a4adf
fix(site/src/pages/AgentsPage/components/ChatMessageInput): drop the …
jaaydenh Oct 21, 2026
fe2c0b3
Merge commit 'e9a4adf7c68e6bf80c9633591e8a99345b3f1dbf' into resync-s…
jaaydenh Oct 21, 2026
9d80261
Merge commit '3216580614^' into resync-skill-editor-form
jaaydenh Oct 21, 2026
793e989
Merge commit '3216580614' into resync-skill-editor-form
jaaydenh Oct 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion site/src/pages/AgentsPage/components/SkillEditor.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { render, screen, waitFor } from "@testing-library/react";
import { act, render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { describe, expect, it, vi } from "vitest";
import { SKILL_MAX_SIZE_BYTES } from "../utils/skills";
Expand Down Expand Up @@ -41,6 +41,39 @@ describe("SkillEditor", () => {
expect(screen.getByRole("button", { name: "Close" })).toHaveFocus(),
);
});

it("keeps an edited skill's name focusable but unchangeable", async () => {
const { user, onSubmit } = renderEditor("edit");
const name = screen.getByRole("textbox", { name: "Name" });
await user.click(name);
expect(name).toHaveFocus();
await user.type(name, "-renamed");
await user.type(screen.getByRole("textbox", { name: "Body" }), " More.");
await user.click(screen.getByRole("button", { name: "Save skill" }));
await waitFor(() =>
expect(onSubmit).toHaveBeenCalledWith(
expect.objectContaining({ name: "existing-skill" }),
expect.any(String),
expect.any(Function),
),
);
});

it("accepts another submit only after the previous one settles", async () => {
const { user, onSubmit } = renderEditor("edit");
await user.type(screen.getByRole("textbox", { name: "Body" }), " More.");
const save = screen.getByRole("button", { name: "Save skill" });
await user.dblClick(save);
await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(1));
await user.click(save);
expect(onSubmit).toHaveBeenCalledTimes(1);

// Settle the first request as a failure, leaving the form open.
const onSettled: () => void = onSubmit.mock.calls[0][2];
act(() => onSettled());
await user.click(save);
await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(2));
});
});

describe("SkillEditor file import", () => {
Expand Down Expand Up @@ -69,6 +102,7 @@ describe("SkillEditor file import", () => {
body: "Use imported instructions.",
},
`---\nname: ${name}\ndescription: "Imported guidance."\n---\nUse imported instructions.\n`,
expect.any(Function),
Comment thread
jaaydenh marked this conversation as resolved.
Resolved
),
);
},
Expand Down Expand Up @@ -105,6 +139,7 @@ describe("SkillEditor file import", () => {
body: "Unsaved instructions.",
},
'---\nname: existing-skill\ndescription: "Existing guidance."\n---\nUnsaved instructions.\n',
expect.any(Function),
),
);
});
Expand All @@ -130,6 +165,7 @@ describe("SkillEditor file import", () => {
body: "Use imported instructions.",
},
'---\nname: imported-skill\ndescription: "Imported guidance."\n---\nUse imported instructions.\n',
expect.any(Function),
),
);
});
Expand Down
Loading
Loading