Repository navigation
feat: add agent-local ACP session interaction - #30831
Merged
hugodutka merged 1 commit intoOct 26, 2026
Merged
Conversation
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 15, 2026 11:04
0162cf0 to
1abacb1
Compare
hugodutka
changed the base branch from
hugodutka/acp-subagents-discovery
to
hugodutka/acp-session-runtime
October 15, 2026 11:06
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 15, 2026 12:05
1abacb1 to
dd506cf
Compare
hugodutka
changed the base branch from
hugodutka/acp-session-runtime
to
hugodutka/acp-session-runtime-tests
October 15, 2026 13:08
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 15, 2026 15:48
dd506cf to
412a03e
Compare
hugodutka
changed the base branch from
hugodutka/acp-session-runtime-tests
to
hugodutka/acp-session-recovery
October 15, 2026 16:12
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 15, 2026 17:31
412a03e to
8f2b9e2
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 16, 2026 15:19
8f2b9e2 to
9abf9e9
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 16, 2026 16:51
9abf9e9 to
2805ba3
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 16, 2026 17:01
2805ba3 to
6d7d999
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
2 times, most recently
from
October 19, 2026 12:58
785534d to
bcecca6
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 19, 2026 13:40
bcecca6 to
a0b501e
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 20, 2026 18:53
b9414e0 to
b4371c3
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 20, 2026 19:01
b4371c3 to
96107ed
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 20, 2026 19:07
96107ed to
79886e5
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 20, 2026 19:28
79886e5 to
7f3c75a
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
2 times, most recently
from
October 21, 2026 12:19
34211b2 to
45d8ee5
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 21, 2026 13:20
45d8ee5 to
b8a4bfe
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 21, 2026 13:36
b8a4bfe to
bd11f2c
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 21, 2026 13:49
bd11f2c to
72da6b4
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 21, 2026 14:19
72da6b4 to
c731ddf
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 21, 2026 14:21
c731ddf to
e89507b
Compare
hugodutka
force-pushed
the
hugodutka/acp-subagents-sessions
branch
from
October 21, 2026 16:12
e89507b to
a0fb450
Compare
mafredri
reviewed
Oct 23, 2026
mafredri
reviewed
Oct 23, 2026
| api.manager.logger.Debug(ctx, "close ACP stream websocket", slog.Error(err)) | ||
| } | ||
| }() | ||
| ctx = conn.CloseRead(ctx) |
Member
There was a problem hiding this comment.
Using this ctx is a bit sketchy here. Due to the websocket upgrade, it will never resolve (until this function returns).
I would suggest using CloseRead(context.Background()) here and overwrite ctx which doesn't serve a purpose within this method any longer. The only time it would be relevant is if we spawned a long-running thing here that we want to stop once this function returns.
Collaborator
Author
There was a problem hiding this comment.
I'll base watchCtx on context.Background too. we wouldn't need the separate streamCtx too.
mafredri
reviewed
Oct 23, 2026
mafredri
reviewed
Oct 23, 2026
mafredri
approved these changes
Oct 26, 2026
Expose session creation, messages, interruption, reads, and event streams through the agent HTTP and WebSocket API and workspace SDK. Adapt runtime watches into subscriptions that complete when the current turn ends. Extend tool call handling to preserve connection deadline control during session setup. Include subscription, API, SDK transport, and agent integration tests. Session lifecycle and restoration are implemented in preceding changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose agent-local ACP session creation, messaging, interruption, transcript reads, and event streams through the agent HTTP and WebSocket API and workspace SDK. Support cursor-based reconnection and extend response write deadlines to allow harness initialization and session recovery to finish.
Depends on #30857.
Generated with Codex, carefully reviewed by Hugo.