Repository navigation
feat: add project skill queries and authorization - #30826
Conversation
Add sqlc queries for skills owned by a chat project and authorize them through the parent project in dbauthz: reading needs chat_project:read and writing needs chat_project:update. Skill.RBACObject keeps denying project rows so any unwrapped path fails closed. Add the chat_project_skill audit resource type and AuditableChatProjectSkill so the upcoming project skill API can record audit entries.
|
@codex review |
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Adds the storage and authorization layer for chat project skills. The
skillstable already allows aproject_idowner (migration 000621); this adds the queries for it and authorizes them through the parent chat project, the same way project instructions work.skills.sql: insert, get by name, list metadata, update (COALESCE on description, content and enabled), delete, andGetProjectSkillByIDForUpdatefor the shared update lock.chat_project:readon the project for reads andchat_project:updatefor writes.authorizeChatProjectInstructionsbecameauthorizeChatProjectConfig, shared by instructions and skills.Skill.RBACObject()still denies project rows so nothing reaches them without going through the project.chat_project_skillresource type (enum-only migration 000624),AuditableChatProjectSkill, and the usual diff/request/table/FriendlyString/AuditFilter wiring. The API that emits these entries comes in the next PR.Stack (merge top to bottom):