Skip to content

feat: add project skill queries and authorization - #30826

Merged
jaaydenh merged 8 commits into
mainfrom
chat-project-skills/queries
Oct 18, 2026
Merged

jaaydenh merged 8 commits into
mainfrom
chat-project-skills/queries

Conversation

@jaaydenh

@jaaydenh jaaydenh commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Adds the storage and authorization layer for chat project skills. The skills table already allows a project_id owner (migration 000621); this adds the queries for it and authorizes them through the parent chat project, the same way project instructions work.

  • New queries in skills.sql: insert, get by name, list metadata, update (COALESCE on description, content and enabled), delete, and GetProjectSkillByIDForUpdate for the shared update lock.
  • dbauthz checks chat_project:read on the project for reads and chat_project:update for writes. authorizeChatProjectInstructions became authorizeChatProjectConfig, shared by instructions and skills. Skill.RBACObject() still denies project rows so nothing reaches them without going through the project.
  • Audit: new chat_project_skill resource type (enum-only migration 000624), AuditableChatProjectSkill, and the usual diff/request/table/FriendlyString/AuditFilter wiring. The API that emits these entries comes in the next PR.

Stack (merge top to bottom):

Add sqlc queries for skills owned by a chat project and authorize them
through the parent project in dbauthz: reading needs chat_project:read
and writing needs chat_project:update. Skill.RBACObject keeps denying
project rows so any unwrapped path fails closed.

Add the chat_project_skill audit resource type and
AuditableChatProjectSkill so the upcoming project skill API can record
audit entries.
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T07:48:42.494623Z 7bc17ba Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 7bc17baca4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nickvigilante nickvigilante left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

Comment thread coderd/database/modelmethods.go Resolved
@jaaydenh
jaaydenh merged commit a379c84 into main Oct 18, 2026
32 checks passed
@jaaydenh
jaaydenh deleted the chat-project-skills/queries branch October 18, 2026 05:58
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants