Skip to content

fix: bump Go version from 1.26.5 to 1.26.9 (backport 2.35) - #30813

Merged
droopy4096 merged 2 commits into
release/2.35from
backport/go-1.26.9-release-2.35
Oct 15, 2026
Merged

droopy4096 merged 2 commits into
release/2.35from
backport/go-1.26.9-release-2.35

Conversation

@droopy4096

@droopy4096 droopy4096 commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Backport of #30807 to release/2.35.

Bumps the Go toolchain from 1.26.5 to 1.26.9. Tracked in Linear: ENT-210 (Iron Bank fix-by date 2026-10-29 for the Critical finding).

Files changed: go.mod, mise.toml, mise.lock (toolchain pin plus the per-platform archive URLs and SHA-256 checksums from the official go.dev/dl list).

Not built or scanned locally; CI will build it.

Companion PR: the module side of GO-2026-6612 (Critical), -6603, -6610, -6611 and -6617 is fixed by golang.org/x/net v0.60.0, backported in #30817 (ENT-211). This PR alone does not clear them; both are needed.

Opened by Superblink on behalf of @droopy4096.

@droopy4096 droopy4096 added community Pull Requests and issues created by the community. cherry-pick/v2.35 Cherry-pick PR targeting release/2.35 labels Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@linear-code

linear-code Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

ENT-210

ENT-212

ENT-215

droopy4096 commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

droopy4096 commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator Author

recheck

@droopy4096

Copy link
Copy Markdown
Collaborator Author

/recheck

cdrci2 added a commit to coder/cla that referenced this pull request Oct 15, 2026
@coder
coder Bot force-pushed the backport/go-1.26.9-release-2.35 branch from cf2258d to c2f6fbe Compare October 15, 2026 14:23
@coder

coder Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

About the failing Analyze PR for Documentation Updates Needed check: this failure is unrelated to the Go bump in this PR.

PRs run the .github/workflows/doc-check.yaml from their base branch. On release/2.34 to release/2.37 that workflow pins coder/agents-chat-action v0.3.0 or older, which calls the /api/experimental/chats routes. Those were removed in #29548 (the API moved to /api/v2 in #28496), so the first chat lookup fails with Coder API error: Not Found. main and release/2.38 pin v0.5.1 (see #29732) and pass.

The check isn't part of required, so it doesn't block merging. A fix that limits doc-check to PRs into main (docs are published from main, so backports need no docs review) is being opened for main and release/2.34 to release/2.37; a link will follow here.

Posted by Superblink on behalf of @droopy4096.

@coder

coder Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Correction to the comment above: the fix doesn't limit doc-check to main. It fixes the cause instead: #30849 bumps coder/agents-chat-action in doc-check.yaml on release/2.35 to v0.5.1, which uses the /api/v2 chat routes (same change as #29732 on main). Once it merges, a rerun of this check should pass.

Posted by Superblink on behalf of @droopy4096.

@coder
coder Bot requested a review from denisra October 15, 2026 15:46
droopy4096 added a commit that referenced this pull request Oct 15, 2026
…30849)

Bumps the pinned `coder/agents-chat-action` in
`.github/workflows/doc-check.yaml` on `release/2.35` from v0.3.0 to
v0.5.1 (`9b3ac42`). Same change as #29732 on `main`.

## Why

The `Analyze PR for Documentation Updates Needed` job fails on every PR
into `release/2.35` (e.g. #30813) with `Coder API error: Not Found`. The
pinned version calls `/api/experimental/chats`, which #29548 removed
after the chat API moved to `/api/v2` (#28496). v0.5.1 calls
`/api/v2/chats`.

v0.5.1 accepts every input this workflow passes (its inputs are a
superset of v0.3.0's), so no other workflow changes are needed. The
doc-check run on this PR is the end-to-end test.

## Changes

- `.github/workflows/doc-check.yaml`: one `uses:` line.

Related:
[ENT-210](https://linear.app/codercom/issue/ENT-210/ironbank-critical-bump-go-to-1269-fix-by-2026-10-29)
(surfaced on the Go 1.26.9 backports).

Opened by Superblink on behalf of @droopy4096.

Co-authored-by: Dmytro Makovey <dmitry@coder.com>
droopy4096 added a commit that referenced this pull request Oct 15, 2026
Bump the Go toolchain from 1.26.5 to 1.26.9 ([released
2026-10-02](https://go.dev/doc/devel/release#go1.26.9)).

Tracked in Linear:
[ENT-210](https://linear.app/codercom/issue/ENT-210/ironbank-critical-bump-go-to-1269-fix-by-2026-10-29).
Iron Bank fix-by date for the Critical finding is **2026-10-29**.

Go 1.26.9 includes fixes for the findings Iron Bank reported against
`coder/coder-enterprise/coder-service-2:2.38.0`. Of the 19 still-valid
advisories, 12 are only fixed in 1.26.9, including the Critical one:

- Critical: [GO-2026-6612](https://pkg.go.dev/vuln/GO-2026-6612) /
CVE-2026-78663 (HTTP/2 server double flow-control refund)
- High: GO-2026-6603, -6605, -6607, -6608, -6609, -6610, -6611, -6613
- Low: GO-2026-6599, -6600, -6617

The other 7 (GO-2026-5026, -5942, -6088, -6089, -6090 High; -6091, -6218
Medium) are fixed since 1.26.6. The full list with links is in ENT-210.

## Changes

Same file set as #27157:

- `go.mod`: `go 1.26.5` to `go 1.26.9`
- `mise.toml` / `mise.lock`: Go toolchain pin and the archive URLs and
SHA-256 checksums for each platform (taken from the official `go.dev/dl`
release list)

## Verification

- `go build ./enterprise/cmd/coder` with go1.26.9 succeeds; `go mod tidy
-diff` is clean.
- `govulncheck -mode binary` on the resulting binary reports none of the
19 advisories above. The same scan of the released 2.38.0 binary
(go1.26.5) reports all 19.

## Not in this PR

`golang.org/x/net` v0.60.0 (the module-side half of GO-2026-6603, -6610,
-6611, -6612 and -6617) is already on `main` via #30772 and is
backported to the release branches in #30814 (2.38), #30815 (2.37),
#30816 (2.36), #30817 (2.35) and #30818 (2.34), tracked in
[ENT-211](https://linear.app/codercom/issue/ENT-211/ironbank-critical-bump-golangorgxnet-to-v0600-on-release-branches-fix).
The Go 1.27.1 bump (#30288) stays a separate, larger change. Go
backports: #30808 (2.38), #30809 (2.37), #30810 (2.36), #30813 (2.35),
#30811 (2.34).

Opened by Superblink on behalf of @droopy4096.
@droopy4096
droopy4096 merged commit e770468 into release/2.35 Oct 15, 2026
30 checks passed
@droopy4096
droopy4096 deleted the backport/go-1.26.9-release-2.35 branch October 15, 2026 19:15
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-pick/v2.35 Cherry-pick PR targeting release/2.35 community Pull Requests and issues created by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants