Repository navigation
fix: bump Go version from 1.25.10 to 1.25.14 (backport 2.29) - #30812
Closed
droopy4096 wants to merge 1 commit into
Closed
droopy4096 wants to merge 1 commit into
droopy4096 wants to merge 1 commit into
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Collaborator
Author
|
Closing: release/2.29 is on Go 1.25, which has no fix for 12 of the 19 advisories in ENT-210 (fixed only in Go 1.26.9 / 1.27.2). A patch-level 1.25.14 bump clears just 6, so it is not worth merging on its own. Decision: leave 2.29 out of this set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #30807 to
release/2.29.Bumps the Go toolchain from 1.25.10 to 1.25.14. Tracked in Linear: ENT-210 (Iron Bank fix-by date 2026-10-29 for the Critical finding). Same approach as the Terraform 1.16.5 backports (#30516 and its backports).
This branch is on Go 1.25, which Go no longer supports. Go 1.25.14 is the latest patch. Files changed:
go.mod,.github/actions/setup-go/action.yamlanddogfood/coder/Dockerfile(version and SHA-256 from the officialgo.dev/dllist). This branch does not usemise.Verified:
go build ./enterprise/cmd/coderwith go1.25.14 succeeds.Partial fix only.
govulncheck -mode binaryon the result still reports 13 of the 19 advisories in ENT-210. The 12 that are fixed only in Go 1.26.9 or 1.27.2 (including the Critical GO-2026-6612) have no Go 1.25 fix, andgolang.org/x/nethere is v0.55.0 (fix: v0.60.0). It does clear the older stdlib advisories fixed in 1.25.13 (for example GO-2026-5026, -6088, -6089, -6090, -6091, -6218). Closing the rest needs Go 1.26 on this branch, which is a larger change; merge this one only if a patch-level bump is wanted on its own.Opened by Superblink on behalf of @droopy4096.