Skip to content

fix: bump Go version from 1.25.10 to 1.25.14 (backport 2.29) - #30812

Closed
droopy4096 wants to merge 1 commit into
release/2.29from
backport/go-1.25.14-release-2.29
Closed

droopy4096 wants to merge 1 commit into
release/2.29from
backport/go-1.25.14-release-2.29

Conversation

@droopy4096

Copy link
Copy Markdown
Collaborator

Backport of #30807 to release/2.29.

Bumps the Go toolchain from 1.25.10 to 1.25.14. Tracked in Linear: ENT-210 (Iron Bank fix-by date 2026-10-29 for the Critical finding). Same approach as the Terraform 1.16.5 backports (#30516 and its backports).

This branch is on Go 1.25, which Go no longer supports. Go 1.25.14 is the latest patch. Files changed: go.mod, .github/actions/setup-go/action.yaml and dogfood/coder/Dockerfile (version and SHA-256 from the official go.dev/dl list). This branch does not use mise.

Verified: go build ./enterprise/cmd/coder with go1.25.14 succeeds.

Partial fix only. govulncheck -mode binary on the result still reports 13 of the 19 advisories in ENT-210. The 12 that are fixed only in Go 1.26.9 or 1.27.2 (including the Critical GO-2026-6612) have no Go 1.25 fix, and golang.org/x/net here is v0.55.0 (fix: v0.60.0). It does clear the older stdlib advisories fixed in 1.25.13 (for example GO-2026-5026, -6088, -6089, -6090, -6091, -6218). Closing the rest needs Go 1.26 on this branch, which is a larger change; merge this one only if a patch-level bump is wanted on its own.

Opened by Superblink on behalf of @droopy4096.

@droopy4096 droopy4096 added community Pull Requests and issues created by the community. cherry-pick/v2.29 Needs to be cherry-picked to the 2.29 release branch labels Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

ENT-210

@droopy4096

Copy link
Copy Markdown
Collaborator Author

Closing: release/2.29 is on Go 1.25, which has no fix for 12 of the 19 advisories in ENT-210 (fixed only in Go 1.26.9 / 1.27.2). A patch-level 1.25.14 bump clears just 6, so it is not worth merging on its own. Decision: leave 2.29 out of this set.

@droopy4096 droopy4096 closed this Oct 14, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-pick/v2.29 Needs to be cherry-picked to the 2.29 release branch community Pull Requests and issues created by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant