Repository navigation
fix: bump Go version from 1.26.5 to 1.26.9 - #30807
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
bb52628 to
786b87c
Compare
|
About the failing The "Test image tooling" step runs Posted by Superblink on behalf of @droopy4096. |
#30851) Fixes the `build_image (26.04)` failure in the `dogfood` workflow on PRs into `main` (seen on #30807). Tracked in [ENT-213](https://linear.app/codercom/issue/ENT-213). ## Problem `lint/go/new-code` (added in #30622) runs `.golangci.new-code.yaml` with `--new-from-merge-base=$(GO_LINT_NEW_CODE_BASE)`, which defaults to `origin/main`. `ci.yaml` sets `GO_LINT_NEW_CODE_BASE` to `HEAD^1` for PRs and `HEAD` otherwise. `scripts/dogfood/test_image.sh` doesn't pass it into the container, and the dogfood checkout (depth 2) has no `origin/main`. So `make lint` inside the image reports the whole tree (1263 issues: errcheck 437, forbidigo 42, nolintlint 784) and fails "Test image tooling". Pushes to `main` run the same validation before pushing the image, so the next dogfood-triggering merge to `main` would also fail and skip the Docker Hub push. ## Change `scripts/dogfood/test_image.sh` only: - Under GitHub Actions, and when `GO_LINT_NEW_CODE_BASE` isn't already set, default it to `HEAD^1` for `pull_request` and `HEAD` otherwise, mirroring `ci.yaml`. - Forward it into the container with `--env GO_LINT_NEW_CODE_BASE`. - Local runs are unchanged: the variable stays unset unless you set it, so the Makefile default (`origin/main`) applies. This PR touches `scripts/dogfood/**`, which triggers the `dogfood` workflow, so its own `build_image (26.04)` run is the end-to-end test. Opened by Superblink on behalf of @droopy4096. Co-authored-by: coder[bot] <137810501+coder[bot]@users.noreply.github.com> Co-authored-by: Dmitry Makovey <dmakovey@yahoo.com>
Backport of #30807 to `release/2.38`. Bumps the Go toolchain from 1.26.5 to 1.26.9. Tracked in Linear: [ENT-210](https://linear.app/codercom/issue/ENT-210/ironbank-critical-bump-go-to-1269-fix-by-2026-10-29) (Iron Bank fix-by date 2026-10-29 for the Critical finding). Same approach as the Terraform 1.16.5 backports (#30516 and its backports). Files changed: `go.mod`, `mise.toml`, `mise.lock` (toolchain pin plus the per-platform archive URLs and SHA-256 checksums from the official `go.dev/dl` list). Verified: `go build ./enterprise/cmd/coder` with go1.26.9 succeeds. `govulncheck -mode binary` on the result no longer reports GO-2026-5026, -5942, -6088, -6089, -6090, -6091, -6218, -6599, -6600, -6605, -6607, -6608, -6609 or -6613. **Companion PR:** the module side of GO-2026-6612 (Critical), -6603, -6610, -6611 and -6617 is fixed by `golang.org/x/net` v0.60.0, backported in #30814 ([ENT-211](https://linear.app/codercom/issue/ENT-211/ironbank-critical-bump-golangorgxnet-to-v0600-on-release-branches-fix)). This PR alone does not clear them; both are needed. Opened by Superblink on behalf of @droopy4096.
Bump the Go toolchain from 1.26.5 to 1.26.9 (released 2026-10-02).
Tracked in Linear: ENT-210. Iron Bank fix-by date for the Critical finding is 2026-10-29.
Go 1.26.9 includes fixes for the findings Iron Bank reported against
coder/coder-enterprise/coder-service-2:2.38.0. Of the 19 still-valid advisories, 12 are only fixed in 1.26.9, including the Critical one:The other 7 (GO-2026-5026, -5942, -6088, -6089, -6090 High; -6091, -6218 Medium) are fixed since 1.26.6. The full list with links is in ENT-210.
Changes
Same file set as #27157:
go.mod:go 1.26.5togo 1.26.9mise.toml/mise.lock: Go toolchain pin and the archive URLs and SHA-256 checksums for each platform (taken from the officialgo.dev/dlrelease list)Verification
go build ./enterprise/cmd/coderwith go1.26.9 succeeds;go mod tidy -diffis clean.govulncheck -mode binaryon the resulting binary reports none of the 19 advisories above. The same scan of the released 2.38.0 binary (go1.26.5) reports all 19.Not in this PR
golang.org/x/netv0.60.0 (the module-side half of GO-2026-6603, -6610, -6611, -6612 and -6617) is already onmainvia #30772 and is backported to the release branches in #30814 (2.38), #30815 (2.37), #30816 (2.36), #30817 (2.35) and #30818 (2.34), tracked in ENT-211. The Go 1.27.1 bump (#30288) stays a separate, larger change. Go backports: #30808 (2.38), #30809 (2.37), #30810 (2.36), #30813 (2.35), #30811 (2.34).Opened by Superblink on behalf of @droopy4096.