Repository navigation
ci: backport relative docs redirects and the removed-route check to 2.38 - #30806
Closed
nickvigilante wants to merge 1 commit into
Closed
nickvigilante wants to merge 1 commit into
nickvigilante wants to merge 1 commit into
Conversation
Backport the docsredirectscheck rewrite from main: relative routes, /* wildcards, and a blocking removed-route check against the base manifest, the live page list for the target branch, and base redirect sources. Wire it into lint and lint-light. Add docs/redirects.json for this branch from the unversioned docs rules that coder.com carries today, resolved to pages that exist in 2.38. Point the contributor docs at docs/redirects.json instead of the coder.com repo. Generated with Coder Agents.
Contributor
|
👋 Hey @nickvigilante! This PR is targeting the Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format: If this is not a bug fix, it likely should not target a release branch. |
Collaborator
Author
|
Closing. Generated by Coder Agents on behalf of @nickvigilante. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports #30805 to
release/2.38with 2.38's owndocs/redirects.json, so the mainline docs (coder.com/docsandcoder.com/beta-docs, currently v2.38) get their redirects from this branch.Part of DOCS-1290; tracked in DOCS-1292.
Changes
scripts/docsredirectscheckand itslint/docs-redirectsMake target, wired intolintandlint-light. This branch had no checker before.deploy-docs.yaml: the redirects rebuild signal from docs: add redirects.json and rebuild the docs site when it changes #30208, so a change to onlydocs/redirects.jsonhere triggers the coder.com rebuild.docs/redirects.json: 311 rules built from coder.com's unversioned docs content rules, with URL-scheme rules (v1,v2,coder-oss,coder/,code-server) left in coder.com.Changes from coder.com's versions:
about/architecturegoes to/.contributing/*is replaced by 9 exact rules, sinceabout/contributinghas no pages.Testing
go test ./scripts/docsredirectscheck/...and the pre-commit hook.go run ./scripts/docsredirectscheck -base origin/release/2.38 -branch release/2.38online: 311 rules OK, 464 routes resolve.curlon all 10 external destinations: 200.Merge order
Merge after #30805 and after the coder.com generator is deployed.
Note
Generated by Coder Agents on behalf of @nickvigilante.