Skip to content

feat: add an API to attach templates to chat projects - #30754

Merged
jaaydenh merged 34 commits into
mainfrom
chat-project-templates/api
Nov 18, 2026
Merged

jaaydenh merged 34 commits into
mainfrom
chat-project-templates/api

Conversation

@jaaydenh

@jaaydenh jaaydenh commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Adds the API for attaching workspace templates to a chat project, on the schema and queries in #32309. A project can attach templates, turn on a limit that restricts its chats to them, and set a default template with either a default preset or default parameter values. Attaching a template never grants access to it: every reader is checked against the template's own sharing. This PR stores and returns limit_templates; #32310 enforces it.

  • The limit is opt-in. limit_templates is off unless a request turns it on, which is what every existing project gets.
  • Templates are attached and detached one at a time with PUT and DELETE /chats/projects/{project}/templates/{template}, so a caller never replaces a list they can only partly see. Attaching needs project update and template use. Detaching needs project update and template read, and a template the caller cannot read is reported as not found. POST /chats/projects accepts template_ids, limit_templates, and default_template for the new project.
  • PATCH /chats/projects/{project} sets limit_templates and default_template, and no longer changes which templates are attached. The default must be an attached template the caller can read, and its preset must belong to the template's active version. Default parameter names and values are checked against that version for templates on the classic parameter flow; dynamic parameters are checked when a workspace is built. Detaching the default template clears the default.
  • Project responses list only the attached templates the caller can read, as templates, and count the rest as hidden_template_count. default_template is omitted when the caller cannot read it. Deleted, deprecated, and agent-disabled templates are left out and are not counted as hidden.
  • Editing uses chat_project:update, which the project owner and the project admin ACL role have.
  • Attaching and detaching are audited as writes to the project, with the template list before and after, including the templates attached while creating a project. Changes to limit_templates and the default template are part of the project's own audit diff.

Not included: showing which project members lack access to an attached template, and MCP server attachments.

Stack (merge top to bottom):

Projects store the templates their chats may use and an optional default
template with either a default preset or default parameter values. An
empty list means the project's chats get no templates. Creating a chat
with, or patching a chat to, a workspace whose template is outside the
project's list is rejected; already bound workspaces are unaffected.
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Docs preview

Links open this pull request's preview at https://pr-30754.docs.cdr-preview.dev, which updates with each push.

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

Preview sites for each built commit (1)

Every built commit keeps its own preview, newest first. Previews aren't indexed by search engines and are deleted when this pull request is merged or closed.

@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T12:54:24.891585Z 437219f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8570509f81

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/exp_chats.go Resolved
Comment thread codersdk/chats.go Resolved
…s/api

# Conflicts:
#	coderd/database/dump.sql
#	coderd/database/models.go
#	coderd/database/queries.sql.go
#	enterprise/audit/table.go
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f68e904cf1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/chat_projects.go Resolved
Comment thread coderd/chat_projects.go Resolved
Comment thread coderd/exp_chats.go Resolved
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 286c8d6281

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/chat_projects.go Resolved
@jaaydenh
jaaydenh added this pull request to stack #30892 October 16, 2026 12:17
Dynamic parameters can appear based on other values, so the stored
parameter rows cannot tell whether a default name is valid. Only
classic-flow templates are checked; the build validates dynamic
defaults when a workspace is created.
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4d16299ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/chat_projects.go Resolved
# Conflicts:
#	coderd/apidoc/docs.go
#	coderd/apidoc/swagger.json
#	coderd/chat_projects.go
#	coderd/database/queries.sql.go
#	coderd/exp_chats.go
#	codersdk/chats.go
#	docs/reference/api/schemas.md
#	site/src/api/typesGenerated.ts
UpdateChatProjectByID now writes the template columns only when the
request sets templates, so a PATCH that omits them cannot restore the
template list and defaults from its stale project snapshot.
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 67f7ef1322

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@linear-code

linear-code Bot commented Oct 21, 2026

Copy link
Copy Markdown

CODAGT-1437

Base automatically changed from chat-project-templates/database to main November 17, 2026 14:59
jaaydenh added a commit that referenced this pull request Nov 17, 2026
Adds the database layer for attaching workspace templates to chat
projects: the schema, the queries, their authorization, and the audit
type. Nothing calls the new queries yet, and the existing create and
update handlers pass the new parameters unset. The API, the limit's
enforcement, and the agent tools follow in the PRs above.

- Attachments live in a `chat_project_templates` table (`project_id`,
`template_id`, `created_by`, `created_at`), deleted with the project or
the template. `chat_projects` gains `limit_templates` (default `false`),
`default_template_id`, `default_template_version_preset_id`, and
`default_parameters jsonb`. A project stores a default preset or default
parameter values, not both.
- `InsertChatProjectTemplates` needs project `update` and `use` on every
template. It skips templates that are already attached, and templates
outside the project's organization, so an attachment never crosses
organizations. `DeleteChatProjectTemplate` needs project `update` and
template `read`, and clears the project's default when it detaches the
default template. Both checks are in dbauthz.
- `GetChatProjectTemplatesByProjectIDs` is authorized through the
project, and leaves out deleted, deprecated, and agent-disabled
templates. It does not check the caller's access to each template, so
callers do that before they expose one.
- `UpdateChatProjectByID` changes the template settings only when the
request sets them, so an update that omits them cannot write back a
stale snapshot.
- `AuditableChatProjectTemplates` is the audit form of a project's
attached templates, logged as a write to the project. The new
`chat_projects` columns are tracked in the project's own audit diff,
with the default parameter values masked because they may hold
credentials.

**NOTE**: the migration adds one table and four columns and changes no
existing rows. Existing projects keep unlimited template access.

Stack (merge top to bottom):
- #32309 👈
- #30754
- #32310
- #30755
- #30756
- #30898
@jaaydenh
jaaydenh temporarily deployed to main November 17, 2026 14:59 — with GitHub Actions Inactive
@jaaydenh
jaaydenh removed this pull request from stack #32311 November 18, 2026 08:06
@jaaydenh
jaaydenh added this pull request to stack #32380 November 18, 2026 08:07
@jaaydenh

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 437219fe76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/database/db2sdk/db2sdk.go Resolved
Comment thread coderd/chat_project_templates.go Resolved
Comment thread coderd/chat_project_templates.go Resolved
Comment thread coderd/chat_project_templates.go Resolved
@jaaydenh
jaaydenh merged commit 17a2b62 into main Nov 18, 2026
33 of 34 checks passed
@jaaydenh
jaaydenh deleted the chat-project-templates/api branch November 18, 2026 13:36
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2026

This branch had an error being deployed

1 failed and 1 inactive deployments
docs-preview — 1331aa4e Deployed Nov 18, 2026 by jaaydenh via cleanup #207
main — 1331aa4e Deployed Nov 18, 2026 by jaaydenh via cla #259469
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants