Repository navigation
fix(site/src/modules/dashboard/Navbar/UserDropdown): announce new tab on version link - #30715
Merged
Merged
Conversation
… on version link The external link icon beside the build version in the user menu is aria-hidden, so screen reader users were not told the link opens in a new tab. Add visually hidden text so the accessible name conveys it. The menu is shared by the dashboard navbar and the Agents sidebar, so this fixes both reports.
tracyjohnsonux
marked this pull request as ready for review
October 13, 2026 22:58
jakehwll
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external link icon beside the build version in the user menu is
aria-hidden, so screen reader users are not told the link opens in a new tab. This adds visually hidden(opens in new tab)text to the link, matching the existing pattern inNavbarView.tsx,SettingsHeader.tsx, andMarkdown.tsx.UserDropdownContentis shared by the dashboard navbar (UserDropdown) and the Agents sidebar (UserSidebarFooter), so this fixes both Deque reports: DEQ-297 (Agents) and DEQ-526 (Header, marked duplicate). A unit test asserts the link's accessible name includes the new-tab text.Verification notes
UserDropdownContent.tsxholds the onlySquareArrowOutUpRightIconwithsize-icon-xsinsite/src, matching both audit selectors.NavbarView.tsx) has no icon.tscare clean.