Skip to content

fix(site/src/modules/dashboard/Navbar/UserDropdown): announce new tab on version link - #30715

Merged
tracyjohnsonux merged 1 commit into
mainfrom
tracy/aria-hidden-version-link
Oct 14, 2026
Merged

tracyjohnsonux merged 1 commit into
mainfrom
tracy/aria-hidden-version-link

Conversation

@tracyjohnsonux

Copy link
Copy Markdown
Collaborator

The external link icon beside the build version in the user menu is aria-hidden, so screen reader users are not told the link opens in a new tab. This adds visually hidden (opens in new tab) text to the link, matching the existing pattern in NavbarView.tsx, SettingsHeader.tsx, and Markdown.tsx.

UserDropdownContent is shared by the dashboard navbar (UserDropdown) and the Agents sidebar (UserSidebarFooter), so this fixes both Deque reports: DEQ-297 (Agents) and DEQ-526 (Header, marked duplicate). A unit test asserts the link's accessible name includes the new-tab text.

Verification notes
  • UserDropdownContent.tsx holds the only SquareArrowOutUpRightIcon with size-icon-xs in site/src, matching both audit selectors.
  • The other version link (prerelease badge in NavbarView.tsx) has no icon.
  • The new test fails without the fix and passes with it; Biome and tsc are clean.
  • Not verified with NVDA in a browser.

🤖 Generated by Coder Agents on behalf of @tracyjohnsonux.

… on version link

The external link icon beside the build version in the user menu is
aria-hidden, so screen reader users were not told the link opens in a
new tab. Add visually hidden text so the accessible name conveys it.

The menu is shared by the dashboard navbar and the Agents sidebar, so
this fixes both reports.
@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

DEQ-297

@tracyjohnsonux
tracyjohnsonux marked this pull request as ready for review October 13, 2026 22:58
@tracyjohnsonux
tracyjohnsonux merged commit 5d5f867 into main Oct 14, 2026
55 of 56 checks passed
@tracyjohnsonux
tracyjohnsonux deleted the tracy/aria-hidden-version-link branch October 14, 2026 02:51
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants