Repository navigation
refactor(site/src/pages/AgentsPage): tighten composer send and file contracts - #30646
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closing stack until can be re-prioritized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up in the #30545 composer refactor stack. Depends on #30639.
This tightens the composer binding contracts so the runtime owns send and file readiness, and removes the branches those contracts made dead.
onSendis optional, and a composer can send only whenonSendis present. The separatehasModelOptionsgate is removed. Callers already fold "no models" intoisDisabled.LoadingChatComposerpasses no send or file callbacks, so it no longer needs theignoreSendstub or empty files.ComposerFileBindingsrequiresonRemoveAttachment,uploadStates,previewUrls,textContents, andworkspaceUploads. Every production caller already supplied them.workspaceUploadsrequired, the "Unsupported file type" branch,shouldRouteFileToWorkspace, and the file pickeracceptattribute were dead and are removed.ChatPageInputdrops its active-upload guard, because the runtime already blocks submission while uploads are in progress.User-visible changes:
Key decisions
isViewOnlystays becausereadOnlyNoticestill drives it.NoModelOptionscomposer story now usesisDisabled, matching how production expresses missing models.Generated by Coder Agents on behalf of @DanielleMaywood.