Skip to content

fix(site/src/pages/AgentsPage): gate workspace removal on workspace selection instead of composer disable - #30645

Closed
DanielleMaywood wants to merge 1 commit into
refactor/agents-remove-chat-inputfrom
fix/agents-workspace-change-gating
Closed

DanielleMaywood wants to merge 1 commit into
refactor/agents-remove-chat-inputfrom
fix/agents-workspace-change-gating

Conversation

@DanielleMaywood

Copy link
Copy Markdown
Collaborator

Follow-up in the #30545 composer refactor stack. Depends on #30639.

The plus menu and the workspace badges used different rules for workspace changes:

  • The plus menu blocked them while workspace selection was loading and allowed them while the composer was disabled.
  • The badge X did the reverse, and the linked-workspace pill offered detach even while workspace selection was loading.

AgentComposerOptions.Provider now derives one changeWorkspace capability, which is absent while workspace selection is loading, and the menu, badges, and pill all read it. The badge X stays visible whenever the caller offers workspace changes and is disabled only while workspace selection loads.

Key decisions
  • Ported from the refactor(site): prototype compound agent composer #30545 reference: the capability lives on the options context value (AgentComposerOptionsValue), not on caller data.
  • Composer disablement does not withdraw workspace changes, which matches the existing plus-menu behavior.
  • isViewOnly still hides the X and pill detach.
  • One table test covers the badge X in a disabled composer and while workspace selection loads.

Generated by Coder Agents on behalf of @DanielleMaywood.

@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

CODAGT-1405

@DanielleMaywood

Copy link
Copy Markdown
Collaborator Author

Closing stack until can be re-prioritized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant