Repository navigation
fix(site/src/pages/AgentsPage): gate voice input on draft locks instead of composer disable - #30643
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
…ad of composer disable
Collaborator
Author
|
Closing stack until can be re-prioritized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up in the #30545 composer refactor stack. Depends on #30639.
The voice input button was gated on
isDisabled(for example, while models load), even though the editor stays editable in that state. It ignoredisLoadingandisReadOnly, where the editor is locked, so dictation could write into a pending or read-only draft. Its Cancel action was also disabled whenever the composer was.startRecordingenforces the same guard. A live recording can always be canceled.Key decisions
startRecordingaction, so compound children that call the action directly get the same contract.Stopenabled assertion was dropped because other streaming tests already click Stop.Generated by Coder Agents on behalf of @DanielleMaywood.