Skip to content

fix(site/src/pages/AgentsPage): gate voice input on draft locks instead of composer disable - #30643

Closed
DanielleMaywood wants to merge 1 commit into
refactor/agents-remove-chat-inputfrom
fix/agents-voice-guard
Closed

DanielleMaywood wants to merge 1 commit into
refactor/agents-remove-chat-inputfrom
fix/agents-voice-guard

Conversation

@DanielleMaywood

Copy link
Copy Markdown
Collaborator

Follow-up in the #30545 composer refactor stack. Depends on #30639.

The voice input button was gated on isDisabled (for example, while models load), even though the editor stays editable in that state. It ignored isLoading and isReadOnly, where the editor is locked, so dictation could write into a pending or read-only draft. Its Cancel action was also disabled whenever the composer was.

  • Voice input is now blocked only while a send is pending or the composer is read-only, matching the editor's own lock.
  • startRecording enforces the same guard. A live recording can always be canceled.
Key decisions
  • The guard lives in both the button and the startRecording action, so compound children that call the action directly get the same contract.
  • The existing "lets a recording start while a turn is streaming" test becomes a table over disabled, pending, and read-only states. Its Stop enabled assertion was dropped because other streaming tests already click Stop.

Generated by Coder Agents on behalf of @DanielleMaywood.

@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

CODAGT-1405

@DanielleMaywood

Copy link
Copy Markdown
Collaborator Author

Closing stack until can be re-prioritized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant