Repository navigation
fix(site/src/pages/AgentsPage): prevent file drop navigation when the composer cannot attach - #30642
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
… composer cannot attach
Collaborator
Author
|
Closing stack until can be re-prioritized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up in the #30545 composer refactor stack. Depends on #30639.
Frameattached its drag handlers only whencanAttachFileswas true. Dropping a file on a composer that could not attach (for example, the create form while organization authorization is pending) left the browser default in place, so the browser navigated away to open the file.The handlers now stay attached. File drags always call
preventDefault. The drag highlight andattachFilesstill requirecanAttachFiles.Key decisions
Frame: dragover and drop callpreventDefaultonly for file drags, so non-file drags reach the editor.AgentCreateFormDelayedOrganizationAuthorizationplay assertion, which now expects the pending drop to be prevented (dispatchEventreturnsfalse) without attaching. It fails without the fix. No Vitest test was added because that story already covers the case.Generated by Coder Agents on behalf of @DanielleMaywood.