Repository navigation
fix(site/src/pages/AgentsPage): ignore portaled Escape and drops in the composer frame - #30640
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
…he composer frame
Collaborator
Author
|
Closing stack until can be re-prioritized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up in the #30545 composer refactor stack. Depends on #30639.
The composer
Framehandled every Escape and drag event that bubbled through its React tree, including events from portaled menus and dialogs. Pressing Escape to close the plus menu while streaming interrupted the stream, and while editing a history message it canceled the edit.Framenow ignores keyboard and drag events whose target is outside its DOM. This replacesFrameEventBoundary, which wrapped only the preview and disconnect dialogs and missed the plus menu.Key decisions
currentTarget.contains(target)) covers every portaled child, soFrameEventBoundaryand its wrappers are removed.preventDefault, matching the oldstopPropagationboundary.Generated by Coder Agents on behalf of @DanielleMaywood.