Repository navigation
refactor(site/src/pages/AgentsPage): remove AgentChatInput - #30639
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
This was referenced Oct 12, 2026
Closed
Closed
Closed
Closed
Collaborator
Author
|
Closing stack until can be re-prioritized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 9 of the stack splitting #30545. Depends on #30638.
Deletes
AgentChatInput.tsx, which no production code renders anymore. Remaining imports now point at the modules that own them:AttachmentPreview,ContextUsageIndicator, andAgentComposerBadges. The tests and stories move toAgentComposers.test.tsxandAgentComposers.stories.tsxand renderChatComposer.There is no intended behavior change. Every test case and story is unchanged in what it renders, does, and asserts. Only the prop shape changes, and the same tests and stories pass.
Key decisions
ChatComposer. Each flatAgentChatInputprop maps ontobindings,model,tools,setup,editor,queue, orcontextusing the valuesAgentChatInputused to forward. Play functions read the same mocks through the nested args. The story title (pages/AgentsPage/AgentChatInput), story export names, and story IDs are unchanged.owner_nameis dropped from two workspace option fixtures because the options type has never included it.AgentComposer.Attachments'onTextPreviewoverride. OnlyAgentChatInputpassed it, so text previews always open the built-in dialog, as they already did in production.isViewOnly, andFrameEventBoundary.ChatComposer's read-only notice and the existing stories still use them, so tightening them would change behavior or force story changes.Generated by Coder Agents on behalf of @DanielleMaywood.