Repository navigation
refactor(site/src/pages/AgentsPage): move chat pages to ChatComposer - #30638
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
This was referenced Oct 29, 2026
Collaborator
Author
|
Closing stack until can be re-prioritized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 8 of the stack splitting #30545. Depends on #30636.
Adds
ChatComposertoAgentComposers.tsxand moves the chat page onto it.AgentChatPagenow builds the composer (ChatPageInputfor a loaded chat,LoadingChatComposerwhile loading) and passes it toAgentChatPageViewandAgentChatPageLoadingViewas acomposernode, so the views no longer forward composer props.There is no intended behavior change. The existing tests and stories pass unchanged apart from edits forced by the new prop shapes.
Key decisions
composer: React.ReactNodepluscanSubmitChatTurn(still used to gate plan implementation and question responses in the timeline). The composer still renders inside the view's context providers.ChatPageInputderives its own read-only state.isReadOnly,readOnlyNotice(owner label wording unchanged), andattachedWorkspacewere computed in the view fromchat, the current user,workspace, andworkspaceAgent. They now come from the same inputs insideChatPageInput, so those props are gone.preferredFoldermoved toAgentChatPagewith the same logic.ChatComposerkeepsreadOnlyNoticeandisViewOnly(not the reference's owner-warning banner), always rendersSubmit(noSaveEditswap), and hides slash commands while editing history.ChatPageInputkeeps the active-upload guard andhasModelOptions. Its props stay flat instead of being regrouped as in the reference.AgentChatPageViewstories wrapper buildsChatPageInputfrom the same defaults the view used to receive, and the loading stories share a smallLoadingChatComposerhelper. The removedisReadOnly={false}props in theChatPageContentstory and test are now derived, and they resolve to the same value because the fixture chat belongs to the story user.Generated by Coder Agents on behalf of @DanielleMaywood.