Skip to content

refactor(site/src/pages/AgentsPage): move the create form to NewAgentComposer - #30636

Closed
DanielleMaywood wants to merge 1 commit into
refactor/agents-composer-optionsfrom
refactor/agents-new-composer
Closed

DanielleMaywood wants to merge 1 commit into
refactor/agents-composer-optionsfrom
refactor/agents-new-composer

Conversation

@DanielleMaywood

@DanielleMaywood DanielleMaywood commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Part 7 of the stack splitting #30545. Depends on #30634.

Adds components/AgentComposers.tsx with two assemblies built from the composer parts:

  • NewAgentComposer now renders the create form composer in AgentCreateForm.
  • LoadingChatComposer now renders the composer in AgentChatPageLoadingView, which keeps its current props.

AgentChatInput stays in place for the chat page consumers. No behavior change is intended. The existing AgentCreateForm, AgentChatInput, and AgentChatPageView tests and stories pass without changes, which shows behavior is preserved.

Key decisions
  • Same tree as AgentChatInput. Each assembly renders the parts AgentChatInput rendered for that caller's props. Stop, InterruptStatus, Warning, and Attachments are left out only where they render nothing for that caller. For example, neither caller streams.
  • hasModelOptions stays a binding. The create form and the loading composer pass it as before, so the runtime's send gate is unchanged. LoadingChatComposer supplies the no-op onSend and empty attachments that the loading view passed to AgentChatInput.
  • LoadingChatComposer keeps Badges. The reference drops the empty badge row. Keeping it preserves the invisible +N pill, which reserves row width and so affects how far the model pill can grow.
  • The create form's isDisabled expression is moved unchanged. The reference's isComposerDisabled regrouping is not applied here. Its automations option does not exist in this base and is not added.
  • Exports added only where imported: ComposerEditorBindings, ComposerDraftBindings, ComposerEditorProps, AgentComposerSetup, and AgentComposerModelProps.

Generated by Coder Agents on behalf of @DanielleMaywood.

@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

CODAGT-1405

@DanielleMaywood

Copy link
Copy Markdown
Collaborator Author

Closing stack until can be re-prioritized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant