Repository navigation
refactor(site/src/pages/AgentsPage): move the create form to NewAgentComposer - #30636
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closing stack until can be re-prioritized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 7 of the stack splitting #30545. Depends on #30634.
Adds
components/AgentComposers.tsxwith two assemblies built from the composer parts:NewAgentComposernow renders the create form composer inAgentCreateForm.LoadingChatComposernow renders the composer inAgentChatPageLoadingView, which keeps its current props.AgentChatInputstays in place for the chat page consumers. No behavior change is intended. The existingAgentCreateForm,AgentChatInput, andAgentChatPageViewtests and stories pass without changes, which shows behavior is preserved.Key decisions
AgentChatInput. Each assembly renders the partsAgentChatInputrendered for that caller's props.Stop,InterruptStatus,Warning, andAttachmentsare left out only where they render nothing for that caller. For example, neither caller streams.hasModelOptionsstays a binding. The create form and the loading composer pass it as before, so the runtime's send gate is unchanged.LoadingChatComposersupplies the no-oponSendand empty attachments that the loading view passed toAgentChatInput.LoadingChatComposerkeepsBadges. The reference drops the empty badge row. Keeping it preserves the invisible+Npill, which reserves row width and so affects how far the model pill can grow.isDisabledexpression is moved unchanged. The reference'sisComposerDisabledregrouping is not applied here. Itsautomationsoption does not exist in this base and is not added.ComposerEditorBindings,ComposerDraftBindings,ComposerEditorProps,AgentComposerSetup, andAgentComposerModelProps.Generated by Coder Agents on behalf of @DanielleMaywood.