Repository navigation
fix(site/src/pages/AgentsPage): defer completion focus until the composer is editable - #30631
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closing stack until can be re-prioritized |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of the stack splitting #30545.
Completion focus in the agent chat composer ran before React committed the state that re-enabled the editor, so the focus call hit a disabled editor and did nothing.
ChatMessageInputRefgainsfocusWhenEditable(). It focuses at the end of the content once the editor is initialized and editable, survives an inner remount, and is consumed by the first successful focus.focus()is now immediate only: it does nothing when the editor is not ready or not editable.focusWhenEditable()on desktop: composer send completion inAgentChatInput, interruptonSettled, ask-user-question responses, and "Implement the plan." inAgentChatPage.isLoadingtransition effect inAgentChatInputand the focus call infinalizeSuccessfulSend, since the composer now owns send completion focus.focus().Generated by Coder Agents on behalf of @DanielleMaywood.