Repository navigation
refactor(site/src/pages/AgentsPage): discriminate upload terminal states - #30630
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
Collaborator
Author
|
Closing stack until can be re-prioritized |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of a stack splitting #30545.
Turns the composer upload states into discriminated unions so terminal payloads only exist on the status that owns them:
UploadState(AttachmentPreview.tsx):uploadedrequiresfileId,errorrequireserror, and in-progress states carry neither.draftWarningstays available on every status.WorkspaceFileUpload(useWorkspaceFileUploads.ts):uploadedrequiresresponse,errorrequireserror.setUploadResultreplaces the state instead of merging it, so no staleerrororresponsesurvives a status change.useChatDraftAttachments.ts: views, registry entries, and snapshots hold a singleuploadStateinstead of loosestatus/fileId/error/draftWarningfields. Draft warnings carry across status transitions as before.?? "Upload failed",upload.response ?branches,&& state.fileId).No behavior change is intended. Cancellation, retry, persistence warnings, and missing map entries are handled the same way as before.
Generated by Coder Agents on behalf of @DanielleMaywood.