Repository navigation
Conversation
The chat transcript dropped every whitespace-only text or reasoning delta. A provider can stream a paragraph break as its own "\n\n" delta, so the live preview showed "writing.Like this" until the saved message replaced it. Interrupted turns stored one part per delta show the same joined text after the turn ends. Whitespace-only text now extends the preceding block of the same type and is dropped only where it would start a block, so a leading whitespace delta still does not end the starting phase.
Member
Author
|
Superseded by #30551. Renaming the branch to drop the unrelated ticket ID closed this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat transcript dropped every whitespace-only
textorreasoningdelta (appendTextBlock,appendText, and the stream state guard in front of them). A provider can stream a paragraph break as its own"\n\n"delta, so the live preview showedwriting.Like thisuntil the saved message replaced it, and markdown that depends on line starts (headings, lists) rendered as inline text until then. Interrupted turns stored one part per delta show the same joined text permanently. #29661 would stop storing new ones that way; this change also renders the existing rows correctly.Whitespace-only text now extends the preceding block of the same type and is dropped only where it would start a block. A leading whitespace delta therefore still leaves the stream state
null, so it does not end the "starting" phase, which is what the old guard was for.Likely the cause of CODAGT-236 (markdown formatting jumps when streaming completes).
These tests fail on
mainand pass here:Decision log
streamState.ts:appendTextBlockalso drops the whitespace when rendering stored messages, andappendTexthad the same check for themarkdownfield, which renders user messages and notices and feeds "Copy message".parsed.markdowncan now end in whitespace when the last part is whitespace, so "Copy message" may include trailing newlines. Emptiness checks inmessageHelpers.tsalready use.trim().