Repository navigation
fix(site/src/components): show a visible indicator on highlighted dropdown options - #30472
Merged
Merged
Conversation
…pdown options Keyboard focus stays in the combobox input while arrow keys move a highlight through the options. The highlight was only a background change with about 1.1:1 contrast, so keyboard users could not see which option Enter would pick (WCAG 2.4.7, 1.4.11). Add a 2px inset content-link ring to highlighted cmdk items in FilterCombobox and the shared CommandItem, and focus-visible rings to the filter chip remove buttons and pointer flyout option buttons, which relied on the browser default outline.
jakehwll
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was generated by Coder Agents on behalf of @chrifro.
In dropdowns built on cmdk, such as the
/workspacessearch and filter, keyboard focus stays in the input while the arrow keys move a highlight through the options. That highlight was only a background change of about 1.1:1 against the menu, so keyboard users couldn't tell which option Enter would pick. This fails WCAG 2.2 SC 2.4.7 Focus Visible and 1.4.11 Non-text Contrast.Changes:
FilterComboboxand the sharedCommandItemnow get a 2px insetcontent-linkring, the same blue as the focus ring on buttons and links. It contrasts 7.0:1 in dark mode and 4.7:1 in light mode.focus-visiblering instead of the browser's default outline.Before / after (
/workspaces, Owner flyout opened with ArrowRight, then ArrowDown):For review: cmdk also highlights the row under the mouse, so the ring shows on hover too. cmdk doesn't record whether the pointer or the keyboard moved the highlight, so a keyboard-only ring would need extra state. I kept the ring for both because the highlighted row is always the one Enter picks.
Verification
/workspaces, keyboard only. The highlighted row's computed style now includes the inset bluebox-shadow, and the chip remove buttons show the blue ring when they have focus.pnpm lintpasses.make pre-commitpasses.