Skip to content

fix(site/src/pages/AgentsPage/components/ChatConversation): pass chatRecordUpdatedAt in chat store test - #30393

Merged
DanielleMaywood merged 1 commit into
mainfrom
fix/chat-store-test-updated-at
Oct 6, 2026
Merged

DanielleMaywood merged 1 commit into
mainfrom
fix/chat-store-test-updated-at

Conversation

@DanielleMaywood

Copy link
Copy Markdown
Collaborator

Fixes the TypeScript error that is failing lint, build, Storybook and test-e2e on main:

chatStore.test.tsx(1946,37): error TS2345: ... Property 'chatRecordUpdatedAt' is missing ... but required in type 'UseChatStoreOptions'.

This was a semantic merge conflict. #29888 made chatRecordUpdatedAt required in UseChatStoreOptions, and b96f1b9 had already added a useChatStore call in chatStore.test.tsx without it. The fix passes chatRecordUpdatedAt: 0, the same value every other call in the file uses.

Verified locally: tsc --noEmit is clean and chatStore.test.tsx passes (80/80).


Generated by Coder Agents.

@DanielleMaywood
DanielleMaywood requested a review from a team as a code owner October 6, 2026 08:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T08:23:33.625764Z 8cf971b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DanielleMaywood
DanielleMaywood enabled auto-merge (squash) October 6, 2026 08:25
jaaydenh added a commit that referenced this pull request Oct 6, 2026
…RecordUpdatedAt in chat store test

main is red after #30167 and #29888 landed together: the new automation
names test omits the now-required chatRecordUpdatedAt option. Same fix as
#30393; the identical hunk merges cleanly once that lands.
@DanielleMaywood
DanielleMaywood merged commit 0ba8079 into main Oct 6, 2026
29 checks passed
@DanielleMaywood
DanielleMaywood deleted the fix/chat-store-test-updated-at branch October 6, 2026 08:30
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants