Repository navigation
refactor(site/src): align compaction settings table - #30274
Conversation
The compaction threshold settings used a custom spinner and inline error text, and put save and cancel in a table footer. Loading now uses `TableLoader`, a successful load with no enabled models uses `TableEmpty`, and a failed load shows `ErrorAlert` above the table instead of repeating the error inside it. Save and cancel sit below the table. Editing, resetting, and organization filtering are unchanged. Pixel will need new snapshots. The loading, empty, and error chrome changed, and the story `Invalid Draft Shows Footer` is now `Invalid Draft Shows Actions`.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cca235d782
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // only for a successful load with no enabled models. | ||
| const blockingError = | ||
| thresholdsError != null || | ||
| (modelsError != null && enabledModels.length === 0); |
There was a problem hiding this comment.
Keep loading until all organization queries settle
When multiple organization model queries run concurrently, one can fail while another remains loading; useOrganizationChatModels then exposes both modelsError and isLoadingModels with an empty model list. This condition treats that intermediate state as blocking, hides the TableLoader, and shows a final-looking error before the remaining request can succeed. Gate the blocking model error on !isLoadingModels so the initial loading state remains stable until every query settles.
AGENTS.md reference: site/AGENTS.md:L11-L11
Useful? React with 👍 / 👎.
Generated by Coder Agents on behalf of Jake Howell.
The compaction threshold settings used a custom spinner and inline error text, and put save and cancel in a table footer. Loading now uses
TableLoader, a successful load with no enabled models usesTableEmpty, and a failed load showsErrorAlertabove the table instead of repeating the error inside it. Save and cancel sit below the table. Editing, resetting, and organization filtering are unchanged.