Skip to content

refactor(site/src): align compaction settings table - #30274

Merged
jakehwll merged 4 commits into
mainfrom
jakehwll/user-compaction-standardisation
Oct 5, 2026
Merged

jakehwll merged 4 commits into
mainfrom
jakehwll/user-compaction-standardisation

Conversation

@jakehwll

@jakehwll jakehwll commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 This PR was modified by Coder Agents on behalf of Jake Howell.

The compaction threshold settings used a custom spinner and inline error text, and put save and cancel in a table footer. Loading now uses TableLoader, a successful load with no enabled models uses TableEmpty, and a failed load shows ErrorAlert above the table instead of repeating the error inside it. Save and cancel sit below the table. Editing, resetting, and organization filtering are unchanged.

The compaction threshold settings used a custom spinner and inline error text, and put save and cancel in a table footer. Loading now uses `TableLoader`, a successful load with no enabled models uses `TableEmpty`, and a failed load shows `ErrorAlert` above the table instead of repeating the error inside it. Save and cancel sit below the table. Editing, resetting, and organization filtering are unchanged.

Pixel will need new snapshots. The loading, empty, and error chrome changed, and the story `Invalid Draft Shows Footer` is now `Invalid Draft Shows Actions`.
@jakehwll
jakehwll marked this pull request as ready for review October 2, 2026 04:31
@jakehwll
jakehwll requested a review from a team as a code owner October 2, 2026 04:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T04:34:09.675657Z cca235d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cca235d782

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

// only for a successful load with no enabled models.
const blockingError =
thresholdsError != null ||
(modelsError != null && enabledModels.length === 0);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep loading until all organization queries settle

When multiple organization model queries run concurrently, one can fail while another remains loading; useOrganizationChatModels then exposes both modelsError and isLoadingModels with an empty model list. This condition treats that intermediate state as blocking, hides the TableLoader, and shows a final-looking error before the remaining request can succeed. Gate the blocking model error on !isLoadingModels so the initial loading state remains stable until every query settles.

AGENTS.md reference: site/AGENTS.md:L11-L11

Useful? React with 👍 / 👎.

Generated by Coder Agents on behalf of Jake Howell.
@jakehwll jakehwll changed the title refactor(site/src/pages/AgentsPage): align compaction settings table refactor(site/src): align compaction settings table Oct 2, 2026
@jakehwll
jakehwll merged commit 8dca7c9 into main Oct 5, 2026
27 checks passed
@jakehwll
jakehwll deleted the jakehwll/user-compaction-standardisation branch October 5, 2026 12:48
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants