Repository navigation
chore: extract recorder construction - #30224
Conversation
|
/coder-agents-review |
|
Chat: Review posted | View chat Review historydeep-review v0.13.0 | Round 2 | Last posted: Round 2, 7 findings (4 P3, 1 P4, 2 Nit), COMMENT. Review Finding inventoryFindings
Contested and acknowledgedCRF-3 (P3, pool.go:91) - newRecorder takes all of PoolOptions
Round logRound 1Netero: no findings (1 Note). Full panel, focused (Go only): ging-go, ryosuke, pariston, mafuuu, bisky, gon, leorio, mafu-san, wildcard meruem (random draw). ging-go and pariston: no findings. Round 2Churn guard: PROCEED (5 addressed, CRF-3 contested). Netero: no findings, verified CRF-1/2/4/5/6 fixes (mutation check on apiKeyID). Fix round (only comments and tests changed; no new files or exported signatures). Panel: ryosuke, meruem (dispute check-in, R1 agents reused via message_agent), bisky, gon, leorio (comments changed), wildcard zoro (random draw). CRF-3 closed 2/2. CRF-10 dropped. Keep-argument: the doc comment duplicates facts in the code and inline comment, so they can drift. Drop reason: Gon and Zoro propose opposite fixes, Leorio verified it accurate, and it follows R1 suggested wording. CRF-11 dropped. Keep-argument: "fail loudly" does not name the panic. Drop reason: "nil embedded client" already tells the reader the failure mode, and Leorio found it informative. 1 new Nit. About deep-reviewCRF = Coder Review Finding (P0-P4, Nit, Note)
|
There was a problem hiding this comment.
This PR moves recorder construction from CachedBridgePool.Acquire into newRecorder and adds TestNewRecorder; the recorder chain it builds is unchanged. 4 P3, 1 P4, 1 Nit.
Out of scope (needs a ticket or explicit acceptance by a human):
aibridge/api.go:91: no test inaibridgecovers the middleware order inNewRecorder, so a reorder there fails onlyTestNewRecorderincoderd/aibridged.aibridge/recorder/filter_recorder.go:44:FilterRecorderandWithoutRecordshave no unit tests; their drop behavior is checked only indirectly.
Notes:
pool.go:102: the deleted field comment said the middleware was "resolved once here rather than on every cache miss";newRecordernow rebuilds it on each cache miss. The cost is negligible next to bridge construction, but the PR description does not mention the change.
🤖 This review was automatically generated with Coder Agents.
|
/coder-agents-review |
There was a problem hiding this comment.
Re-review of a9e175e, which rewrites the two newRecorder comments, adds an APIKeyID subtest, and moves test expectations into the table. 1 new Nit.
The two comment findings, the missing apiKeyID assertion, the computed test expectations, and the id rename are fixed; the new subtest fails when a different key is passed to NewDRPCRecorder. The PoolOptions parameter finding is closed (see the reply on that thread).
🤖 This review was automatically generated with Coder Agents.
9f6762e to
386352e
Compare
f3a95f4 to
e6beea7
Compare
e6beea7 to
0e86233
Compare
Extract
newRecorderfrom the interception pool into helper.This lets the proxy use the same recorder construction code.
Generated by Coder Agents on behalf of @pawbana.