Repository navigation
Conversation
Contributor
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds workspace secrets that are set inline on a workspace or build request and delivered only through the agent manifest. This is the coderd half of RELAY-7: agent-relay modules can stop passing provider credentials as rich parameters, which land in
workspace_build_parameters, Terraform state, insights, and Prometheus.Closes RELAY-7 on the coderd side. Supersedes #29739.
What changed
workspace_secretstable. Each row is linked to one build (workspace_build_id). Columns mirroruser_secrets(dbcrypt-encryptedvalue,env_name/file_pathtargets) plusephemeralandcleared_at. Per-build caps via a trigger with the same limits as user secrets.CreateWorkspaceRequest.secretsandCreateWorkspaceBuildRequest.secrets(WorkspaceSecretInput{name, value, env_name, file_path, ephemeral}). Applied inside the wsbuilder transaction; never placed in the provisioner job input.value = NULL,cleared_at = now()). Cleared rows stay as history of what each build received.rotate/decryptcover the new table;deleteclears values instead of dropping rows.docs/admin/security/secrets.md.Follow-ups (out of scope)
secretsinstead ofagent_relay_credential.GetWorkspaceSecretsHistory).Design decisions
secretsstill carries the set forward.ActionUpdateon the workspace, so the relay's service account works the same way it does withrich_parameter_values. The copy-forward read runs as system inside the transaction; values are only re-inserted for the same workspace and never returned."value": ""omits the secret from the new build; the previous row is cleared like any other.env_name/file_path.Created by Coder Agents on behalf of @Emyrk.