Repository navigation
feat: show coder sharing in CLI help and reference docs - #30141
nickvigilante merged 3 commits into
Conversation
Documentation CheckUpdates Needed
Automated review via Coder Agents |
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e345fea65
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Yes we should, and I'll make that tweak! |
|
@matifali Added in 37d6b56: Generated by Coder Agents on behalf of @nickvigilante. |
aslilac
left a comment
There was a problem hiding this comment.
lol oops. that's a little embarrassing.
`coder sharing` has been hidden since it was added behind an experiment, although Shared Workspaces is GA and the prose docs already use it. Linear: CLI-22
Now that coder sharing has generated reference pages, point the shared workspaces guide and the persistent shared workspaces tutorial at them. Linear: CLI-22
Both subcommands update the workspace ACL, which fails when workspace sharing is disabled for the deployment or the organization's sharing policy doesn't allow it. The status subcommand only reads the ACL and isn't affected, so it has no note.
37d6b56 to
e370e77
Compare
coder sharinghas been hidden since it was added behind an experiment, although Shared Workspaces is GA and the prose docs already use it.This removes
Hidden: true, regeneratesdocs/reference/cli/sharing/*, and adds the pages to the docs manifest.The shared workspaces guide and the persistent shared workspaces tutorial now link to the new reference.
Behavior change:
coder sharingand its subcommands now appear incoder --help.The commands themselves are unchanged.
The
sharing remove --user/--grouphelp text previously said "to share the workspace with"; it now says "to remove from the workspace".Decisions
DELETE /workspaces/{workspace}/aclhas no CLI caller.Closes CLI-22
This PR was generated by Coder Agents on behalf of @nickvigilante.