Skip to content

test(site/src/pages/AISettingsPage/SpendPage): wait for the cleared spend request - #30132

Merged
ssncferreira merged 1 commit into
mainfrom
spend-filter-test-flake
Sep 30, 2026
Merged

ssncferreira merged 1 commit into
mainfrom
spend-filter-test-flake

Conversation

@tracyjohnsonux

Copy link
Copy Markdown
Collaborator

Fixes the applies and clears the $key filter test from #30128, which failed on main (run) with expected 'openai' to be undefined.

When the filter is cleared, the URL updates before the spend report is requested again. The test checked the last request right after the URL changed, so on a slow runner it still saw the earlier provider_name: "openai" request. It now waits for the request without the filter.

Verified with 5 consecutive local runs of SpendPage.test.tsx, plus pnpm lint:types and biome check.


Generated by Coder Agents on behalf of @tracyjohnsonux.

@ssncferreira ssncferreira left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch 👍

@ssncferreira
ssncferreira merged commit 95c9dca into main Sep 30, 2026
49 of 50 checks passed
@ssncferreira
ssncferreira deleted the spend-filter-test-flake branch September 30, 2026 11:46
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants