Repository navigation
feat: recognize VS Code forks and JetBrains IDEs as session apps - #30116
Conversation
The VS Code extension will report vscode.env.uriScheme as its app name. Add the schemes missing from the registry so their sessions total under the VS Code family instead of unknown: code_oss, vscodium_insiders, trae_cn, and devin_next. Rename devin to Devin Desktop.
The JetBrains plugins will report one name per IDE, derived from its product code. Register them under the JetBrains family so the agent keeps skipping per-session counts for JetBrains' many SSH sessions. Sync the 000596 down migration's registry copy with the new keys.
This ties into what I was saying about the families on another PR, the fact that we still need coderd changes to properly display new apps is I think a problem. Either clients need to report their own family, or we have to somehow get rid of the family grouping altogether. Maybe for the tracking issue at least maybe there is some different method we could use to determine Jetbrains...not sure though. I am actually not sure Toolbox does open hundreds of sessions, I think they only open the one now, so maybe it is not as big a deal anymore. |
|
Once the scalable IDEs project fully lands then yes we don't need these groups except in a few places. Like we never store the family and we don't need it. Even the dashboard could potentially show apps instead of families. So I think long term, families will go. Potentially, we could send families yes but tbh families are always represented at runtime so even if this lands in the next patch or release it's not a problem except in places where we deliberately show families only and this would fix itself in the next release. |
|
Awesome!! Yeah the display can always be fixed later so not a huge deal, but the Jetbrains counter does sound sketchy if we end up logging hundreds of connections because we get some new IDE not categorized as Jetbrains yet 😢 honestly I think that whole jetbrains watcher thing needs to be reevaluated at some point |
|
Yeahh I haven't dug into the jetbrains thing yet but it def has to be fixed before we start counting their apps.. |
The VS Code extension (CLIENT-643) and the JetBrains plugins (JET-5) will report the specific IDE instead of
vscodeorjetbrains. This registers those names ahead of the clients, so each IDE gets its display name, icon, and family as soon as a client sends it, instead of landing underunknown.VS Code forks
The extension sends
vscode.env.uriScheme, with hyphens folded to underscores. Four schemes were missing:code-osscode_ossvscodium-insidersvscodium_insiderstrae-cntrae_cndevin-nextdevin_nextdevinis renamed to "Devin Desktop".windsurfstays separate, since Windsurf builds from before the rename still report it.JetBrains IDEs
The plugins map the IDE's product code to one name per IDE, whatever the edition, as specified in JET-5:
intellij,pycharm,goland,webstorm,phpstorm,rubymine,clion,rider,rustrover,datagrip,dataspell,mps, andandroid_studio. The keys match the bundled icons.These must be registered before the plugins ship. The agent skips per-session counting for the JetBrains family, because JetBrains opens hundreds of SSH sessions (
agent/agentssh/agentssh.go). An unregisteredgolandfalls underunknown, so each of those sessions would be counted.What admins see once the clients ship
jetbrainsby default, because the agent's channel watcher reports the family. Only theworkspace-usageexperiment path carries the IDE name. JET-5 covers the watcher.Other changes
ssh.Closes #29928