Skip to content

feat: recognize VS Code forks and JetBrains IDEs as session apps - #30116

Merged
EhabY merged 2 commits into
mainfrom
ehab/session-apps-vscode-forks
Sep 29, 2026
Merged

EhabY merged 2 commits into
mainfrom
ehab/session-apps-vscode-forks

Conversation

@EhabY

@EhabY EhabY commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

The VS Code extension (CLIENT-643) and the JetBrains plugins (JET-5) will report the specific IDE instead of vscode or jetbrains. This registers those names ahead of the clients, so each IDE gets its display name, icon, and family as soon as a client sends it, instead of landing under unknown.

VS Code forks

The extension sends vscode.env.uriScheme, with hyphens folded to underscores. Four schemes were missing:

Scheme Key Display name
code-oss code_oss Code - OSS
vscodium-insiders vscodium_insiders VSCodium Insiders
trae-cn trae_cn Trae CN
devin-next devin_next Devin Desktop Next

devin is renamed to "Devin Desktop". windsurf stays separate, since Windsurf builds from before the rename still report it.

JetBrains IDEs

The plugins map the IDE's product code to one name per IDE, whatever the edition, as specified in JET-5: intellij, pycharm, goland, webstorm, phpstorm, rubymine, clion, rider, rustrover, datagrip, dataspell, mps, and android_studio. The keys match the bundled icons.

These must be registered before the plugins ship. The agent skips per-session counting for the JetBrains family, because JetBrains opens hundreds of SSH sessions (agent/agentssh/agentssh.go). An unregistered goland falls under unknown, so each of those sessions would be counted.

What admins see once the clients ship

Other changes

  • The 000596 down migration's copy of the registry gets the new keys. 000596 is unreleased, so a downgrade from 2.38 folds them into the right family instead of ssh.
  • A test pins every name a client can report to its key, family, and display name.

Closes #29928

The VS Code extension will report vscode.env.uriScheme as its app name.
Add the schemes missing from the registry so their sessions total under
the VS Code family instead of unknown: code_oss, vscodium_insiders,
trae_cn, and devin_next. Rename devin to Devin Desktop.
The JetBrains plugins will report one name per IDE, derived from its
product code. Register them under the JetBrains family so the agent keeps
skipping per-session counts for JetBrains' many SSH sessions. Sync the
000596 down migration's registry copy with the new keys.
@EhabY EhabY changed the title feat(codersdk): register VS Code fork URI schemes as session apps feat: register VS Code fork and JetBrains IDE names as session apps Sep 29, 2026
@EhabY EhabY changed the title feat: register VS Code fork and JetBrains IDE names as session apps feat: recognize VS Code forks and JetBrains IDEs as session apps Sep 29, 2026
@EhabY
EhabY requested a review from code-asher September 29, 2026 17:53

@code-asher code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@code-asher

code-asher commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

These must be registered before the plugins ship

This ties into what I was saying about the families on another PR, the fact that we still need coderd changes to properly display new apps is I think a problem.

Either clients need to report their own family, or we have to somehow get rid of the family grouping altogether.

Maybe for the tracking issue at least maybe there is some different method we could use to determine Jetbrains...not sure though. I am actually not sure Toolbox does open hundreds of sessions, I think they only open the one now, so maybe it is not as big a deal anymore.

@EhabY

EhabY commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Once the scalable IDEs project fully lands then yes we don't need these groups except in a few places. Like we never store the family and we don't need it. Even the dashboard could potentially show apps instead of families.

So I think long term, families will go.

Potentially, we could send families yes but tbh families are always represented at runtime so even if this lands in the next patch or release it's not a problem except in places where we deliberately show families only and this would fix itself in the next release.

@code-asher

Copy link
Copy Markdown
Member

Awesome!!

Yeah the display can always be fixed later so not a huge deal, but the Jetbrains counter does sound sketchy if we end up logging hundreds of connections because we get some new IDE not categorized as Jetbrains yet 😢

honestly I think that whole jetbrains watcher thing needs to be reevaluated at some point

@EhabY

EhabY commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Yeahh I haven't dug into the jetbrains thing yet but it def has to be fixed before we start counting their apps..

@EhabY
EhabY merged commit 0285a3c into main Sep 29, 2026
36 of 37 checks passed
@EhabY
EhabY deleted the ehab/session-apps-vscode-forks branch September 29, 2026 20:41
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend the session app registry with JetBrains products and VS Code fork aliases

2 participants