Repository navigation
Conversation
Contributor
Author
|
Closing because this has served its purpose. |
This was referenced Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2904
Things aren't named quite right yet but here's a start! I plan to add to this but wanted to share early.
requirements as I understand them:
enabledin the license data must be available (soft enforcement)enabled: false, but we should decide how the API will handle this caseentitledisfalsewill show a warning, but the admin will be able to enable the feature (soft enforcement)Solution:
licenseXServicefetches license data on app mount, refresh, and various events and holds license data in global stateLicenseBannerdisplays any warningsLicenseRequiredpage wrapper redirects OSS users to another page (currently 404, will later be something more informative) if they try to access a page that is entirely a paid featurelicenseXServiceto determine whether to show smaller features (coming next)