Repository navigation
fix: strip client actor headers unconditionally - #30037
Merged
Merged
Conversation
Contributor
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
johnstcn
commented
Sep 28, 2026
johnstcn
force-pushed
the
fix/strip-client-actor-headers
branch
from
September 28, 2026 10:18
5d53484 to
130ac45
Compare
johnstcn
force-pushed
the
fix/strip-client-actor-headers
branch
from
September 29, 2026 19:00
130ac45 to
cec5ec0
Compare
johnstcn
force-pushed
the
fix/strip-client-actor-headers
branch
from
September 29, 2026 19:07
cec5ec0 to
52c2657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip all client-supplied headers matching
IsActorHeader()inPrepareClientHeaders, regardless ofsend_actor_headers. This reserves the case-insensitiveX-AI-Bridge-Actorprefix for identity injected by the gateway. Remove the redundant deletion of the three standard actor headers fromBuildUpstreamHeaders.Behavior change: intercepted requests no longer pass client actor-prefixed headers upstream when actor forwarding is off, including custom names under that prefix. Authenticated actor injection when enabled, non-prefixed headers, and passthrough routes are unchanged.
Depends on #29930. Follow-up to Lisa's review, kept separate from email opt-in.
Implementation and verification
go test ./aibridge/... ./coderd/aibridged/..., focused race tests, and full pre-commit generation, formatting, lint, and build checks.Generated with Coder Agents on behalf of @johnstcn.