Repository navigation
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be4dc00d0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
7391ba5 to
18554df
Compare
18554df to
365a83e
Compare
365a83e to
52ba29c
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52ba29c684
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
52ba29c to
b556287
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5562875b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b556287 to
4511890
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4511890a92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Documentation CheckUpdates Needed
Automated review via Coder Agents |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
944c6ea to
9b504ad
Compare
Add GET /api/experimental/experiments/rules and
PUT /api/experimental/experiments/rules/{experiment}. The handler
authorizes before parsing, validates before auditing, writes through
experiments.WriteRule, audits effective changes and failures after
commit, and skips auditing identical writes. Responses are no-store.
Add ExperimentalClient.ExperimentRules and PutExperimentRule, the hidden
coder exp experiment-rules list|on|off|set|reset command, a startup
default note on the Deployment Overview page, and a docs section in
feature-stages.md.
Signed-off-by: Thomas Kosiewski <tk@coder.com>
Signed-off-by: Thomas Kosiewski <tk@coder.com>
…ites are not audited Signed-off-by: Thomas Kosiewski <tk@coder.com>
…names The rules API returns an empty mode for a malformed stored rule and arbitrary experiment names for ignored rows, but the response types reused the closed ExperimentRuleMode and Experiment enums. Make ExperimentRule.Mode and ExperimentRuleEntry.Experiment plain strings so generated clients can represent both; the write request keeps the closed mode enum. Signed-off-by: Thomas Kosiewski <tk@coder.com>
… rules parseStoredRule can no longer fail after WriteRule started treating a row without a readable positive revision as revision 0, so drop its error and unused parameter and update the ReadRules doc. Cover an unreadable row listed at revision 0 and replaced through PUT with expected revision 0.
Revision 0 in a listed rule means the stored rule has no readable positive revision and is malformed, not that it was never configured; expected revision 0 also replaces such a rule. Regenerate the API docs and TypeScript types.
…ule conditions Audit entries now track the condition, and enterprise servers export every audit entry to the server log. Document that, keep the promise that no other log line carries the text, and make the redaction test export audit lines to the captured log so it checks the promise as written.
9b504ad to
077f05c
Compare
Slice 4 of 4 for runtime experiment rules: an experimental management API and a hidden CLI, so admins can target, widen, or kill a user-scoped experiment at runtime without a redeploy. This PR also adds a startup-default note on the Deployment Overview page and a docs section.
What's in it
/api/experimental/experiments/rules(behindapiKeyMiddlewareandhttpmw.NoStore):GETreturns, per user-scoped experiment, the startup default and the stored rule (mode, condition, revision, actor, time). Stored rules for other experiments follow, markedignored.PUT /{experiment}takes{mode, condition?, expected_revision}.DeploymentConfigbefore parsing anything. A denied request gets 403 and is not audited.experiments.WriteRule. A stale revision returns 409 and a transaction error returns 500; both are audited with an empty diff.ExperimentalClient.ExperimentRulesandExperimentalClient.PutExperimentRule.coder exp experiment-rules list|on|off|set|reset.--expected-revision. Without it they read the current revision first, which only protects the gap between the two calls; the help text says so.resetwarns when the startup default is on, because reset is not a kill switch.docs/reference/feature-stages.mdcovers the modes, roles, CEL fields and limits, reset vs. off, revisions and audit, the kill-switch guarantee (including the rolling-upgrade requirement), frontend freshness, fail-closed behavior, and that rules are not an authorization boundary.Testing
/api/v2/experimentsand by B's evaluator, which is the one chatd uses./deployment/config, the support bundle, and telemetry. The test wires the slog audit backend so this is checked as stated.Remote dogfood UAT through Coder Agents passed on a licensed test deployment:
/deployment/config, the support bundle and the audit API (at that head the audit still masked the condition; it is now tracked);offandreset;That round tested
135aaaa41e. The later commits are a CLI refactor and a test addition, and a follow-up round will cover the final head.Follow-ups (low, not in this PR)
ignored.updated_byandupdated_atvalues instead of omitting them.user.*fields.PutExperimentRuleRequest.modeis not in the Swaggerrequiredlist. An omitted mode already returns 400.Stack
Note
This PR was written by an AI agent (Xum).
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high