Repository navigation
refactor(site/src/pages/AgentsPage): remove unused tool call props - #29909
Merged
DanielleMaywood merged 2 commits intoOct 6, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DanielleMaywood
force-pushed
the
nullability/conversation-tools
branch
2 times, most recently
from
September 29, 2026 14:29
8fd105a to
68e6991
Compare
DanielleMaywood
force-pushed
the
nullability/tool-cleanups
branch
from
September 29, 2026 14:41
ebfa837 to
4f3ff5a
Compare
jaaydenh
approved these changes
Sep 30, 2026
jakehwll
approved these changes
Oct 6, 2026
DanielleMaywood
merged commit Oct 6, 2026
75a2e38
into
nullability/conversation-tools
27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #29891.
Removes dead props and a redundant null check from the tool-call rows, and fixes one blank-label bug.
ToolCall.tsx: deleted four props that no caller insite/srcpasses, including stories and tests:Root.view,Root.onViewChange,Label.shimmerWhenActive(always the defaulttrue), andHeader.headerClassName.Rootstays controllable withexpanded.ProcessOutputTool.tsx:modelIntent ? sanitizeExecuteModelIntent(modelIntent, cmd) : ""becomes a direct call.sanitizeExecuteModelIntentalready returns""forundefined.Behavior change (separate commit): in
GenericToolRenderer(Tool.tsx), the label wasmodelIntent ? formatModelIntentLabel(modelIntent) : <ToolLabel />.model_intentis the raw string from the model, so it can be whitespace only. In that caseformatModelIntentLabelreturned""and the header showed a blank label. It now usesformatModelIntentLabel(modelIntent) || <ToolLabel />, so blank intents fall back to the default tool label. A new Vitest case inTool.test.tsxcovers this: it fails without the fix and passes with it. It checks the header button's accessible name, which is the non-visual result of the label.Overlap: #29894 also edits
Tool.tsx. This PR changes only thelabelexpression inGenericToolRenderer.Part of the AgentsPage nullability cleanup; see #29888 for the methodology.
Verified:
pnpm lint:types,check,lint:oxlint,lint:compiler,lint:knip,pnpm test src/pages/AgentsPage(1618 passed), andpnpm test:storybook src/pages/AgentsPage/components/ChatElements/tools/(12 files, 230 passed).Plan excerpt
8. Top-down pass proposals
Analysed on a local, unpushed merge of all cleanup branches; ranking script
topdown.cjs. After the bottom-up PRs only 43 dead slots remain, so what's left is nullability that is real at its origin. Two read-only agents reviewed the top origins in code. Guard counts from the tool overstate the win: many "guards" are real branches (loading, no workspace, first/last row).chatId ??/ternary inChatPageInput; 4 never-passedToolCallprops; redundantworkspace ?atAgentChatPageView.tsx:459; redundant ternary inProcessOutputTool; redundant count check atAgentChatInput.tsx:1142Tool.tsx:1017||fallback changes whitespace-only intents to show the default label (a fix)The
ChatPageInput,AgentChatPageView, andAgentChatInputparts of T7 are in #29907, stacked on #29890.This PR was generated by Coder Agents on behalf of @DanielleMaywood.