Repository navigation
refactor(site/src/pages/AgentsPage): require non-null context usage in the indicator - #29905
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DanielleMaywood
force-pushed
the
nullability/chat-input
branch
from
September 29, 2026 14:29
b008dba to
064e2a8
Compare
DanielleMaywood
force-pushed
the
nullability/context-usage
branch
from
September 29, 2026 14:49
f837077 to
9485e03
Compare
jakehwll
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #29890.
ContextUsageIndicatoracceptedusage: AgentContextUsage | nulland read every field withusage?.. Inside the indicator,nulland{}render the same thing: every field is missing. The indicator is hidden whenAgentChatInputgets nocontextUsageprop, and that stays true.ChatPageContentnow always builds one usage object:{ ...rawUsage, compressionThreshold, context: chatContext }. Before, it passednullwhen there was no usage and no pinned context. In that case the new object only addscompressionThreshold, and the indicator only shows it when a percentage exists. A percentage needsusedTokensandcontextLimitTokens, and neither is set in that case, so the output is the same.AgentChatInputProps.contextUsageis nowAgentContextUsage(optional, no null), andContextUsageIndicator.usageis now required and non-null. This replaces 14usage?.reads withusage..NoUsagestory arg is now{}instead ofnull.ChatPageContentis the only production caller that passescontextUsage. The otherAgentChatInputcallers leave it out, so the indicator stays hidden for them.Verified:
pnpm lint:types,check,lint:oxlint,lint:compiler,lint:knip,pnpm test src/pages/AgentsPage, andpnpm test:storybookforContextUsageIndicator,AgentChatInput,ChatPageContent,AgentChatPageandAgentChatPageViewstories.Part of the AgentsPage nullability cleanup; see #29888 for the methodology.
Plan excerpt
Analysed on a local, unpushed merge of all cleanup branches; ranked with a local analysis script. After the bottom-up PRs only 43 dead slots remain, so what's left is nullability that is real at its origin. Two read-only agents reviewed the top origins in code. Guard counts from the tool overstate the win: many "guards" are real branches (loading, no workspace, first/last row).
ContextUsageIndicator.usage: build the usage object once inChatPageContent(null behaves exactly like{}), makeusagenon-null; omitted prop keeps meaning "hidden"usage?.NoUsagestory arg becomes{}This PR was generated by Coder Agents on behalf of @DanielleMaywood.