Repository navigation
refactor(site/src/pages/AgentsPage): carry diff status in git panel PR tab - #29904
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
DanielleMaywood
force-pushed
the
nullability/right-panel
branch
from
September 29, 2026 14:29
1ed8418 to
52f103b
Compare
DanielleMaywood
force-pushed
the
nullability/git-pr-diff-status
branch
from
September 29, 2026 14:35
f421a07 to
034704d
Compare
DanielleMaywood
force-pushed
the
nullability/git-pr-diff-status
branch
from
October 6, 2026 08:07
034704d to
4543343
Compare
DanielleMaywood
force-pushed
the
nullability/git-pr-diff-status
branch
from
October 6, 2026 11:13
4543343 to
87f329f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoteDiffPanelonly renders for a PR tab, and a PR tab only exists when a PR number can be derived fromchat.diff_status(pr_numberor parsed fromurl).AgentChatPageViewnow buildsprTabwith thatdiffStatusinside it,GitPanel'sRemoteContentpassesprTab.diffStatusdown, andRemoteDiffPanel.diffStatusis required, removing itsdiffStatus?.guards.Still nullable on purpose:
GitPanel.remoteDiffStats(branch pushed without a PR) anddiffStatus.urlwith the queryenabledguard (a PR number can exist without a URL). The deadagentId &&check was dropped becauseagentIdischat.id.Stories: PR stories use a
makePrArgshelper that buildsprTabandremoteDiffStatsfrom one object, as production does.EmptyStatepassed aprTabwithout any diff status, which production cannot produce; it now uses a diff status withpr_numberand no URL, which renders the same.AgentChatPageView.tsxis also edited by #29890, but in other regions (props types, ~131-180, 301, 1057-1075). This diff only touches the prTab region (~344-350, 691, 701), so the two should merge cleanly.Verified:
pnpm lint:types,check,lint:oxlint,lint:compiler,lint:knip,pnpm test src/pages/AgentsPage(1877 passed), andpnpm test:storybookforGitPanelandAgentChatPageViewstories (81 passed).Part of the AgentsPage nullability cleanup; see #29888 for the methodology.
Plan excerpt
8. Top-down pass proposals
Analysed on a local, unpushed merge of all cleanup branches; after the bottom-up PRs only 43 dead slots remain, so what's left is nullability that is real at its origin. Two read-only agents reviewed the top origins in code. Guard counts from the tool overstate the win: many "guards" are real branches (loading, no workspace, first/last row).
diff_statusinsideprTab, makeRemoteDiffPanel.diffStatusrequired (it can only render when a PR exists)EmptyStatestory fixedThis PR was generated by Coder Agents on behalf of @DanielleMaywood.