Repository navigation
refactor(site/src/pages/AgentsPage): return normalized line stats from getChatDisplayConfig - #29903
Closed
DanielleMaywood wants to merge 1 commit into
Closed
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
DanielleMaywood
force-pushed
the
nullability/sidebar-line-stats
branch
from
September 29, 2026 14:35
bef84d5 to
9440605
Compare
DanielleMaywood
marked this pull request as ready for review
September 29, 2026 14:46
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jaaydenh
approved these changes
Oct 2, 2026
DanielleMaywood
force-pushed
the
nullability/sidebar-line-stats
branch
from
October 6, 2026 08:10
9440605 to
204d333
Compare
…m getChatDisplayConfig
DanielleMaywood
force-pushed
the
nullability/sidebar-line-stats
branch
from
October 6, 2026 11:16
204d333 to
3734e8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #29889.
getChatDisplayConfigreturned the rawdiff_status, and bothChatTreeNodeandChatSearchResultsre-derived the same line stats from it (?? 0defaults plus aurl && (a > 0 || d > 0 || c > 0)check). It now returnslineStats: { additions, deletions, changedFiles } | undefined, defined only whendiff_status.urlis set and at least one count is positive, which is the exact condition both callers used. Both callers render fromlineStats, thegetChatDiffStatuspassthrough is deleted, and the doubledPRIcon && prIconcheck becomesprIcon && <prIcon.icon />. No behavior or DOM change.Part of the AgentsPage nullability cleanup; see #29888 for the methodology.
Verified:
pnpm lint:types,pnpm check,pnpm lint:oxlint,pnpm lint:compiler,pnpm lint:knip,pnpm test src/pages/AgentsPage, andpnpm test:storybookonChatsSidebar,ChatSearchDialog, andSidebarTabViewstories.Plan excerpt
Analysed on a local, unpushed merge of all cleanup branches; ranking script
topdown.cjs. After the bottom-up PRs only 43 dead slots remain, so what's left is nullability that is real at its origin. Two read-only agents reviewed the top origins in code. Guard counts from the tool overstate the win: many "guards" are real branches (loading, no workspace, first/last row).getChatDisplayConfigreturns normalizedlineStatsinstead of rawdiffStatus; deletegetChatDiffStatus; drop doubledPRIcon && prIconThis PR was generated by Coder Agents on behalf of @DanielleMaywood.